Skip to content

JOSS review: Add a unit test for materials with known tortuosity factor #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ma-sadeghi opened this issue Jun 28, 2023 · 1 comment
Closed

Comments

@ma-sadeghi
Copy link

This is not urgent, but I think it's important: Currently, most of the unit tests (maybe all?) test the edge cases like "tortuosity of open space should be 1" or "tortuosity of a closed space should be infinity", which are indeed required. I think what's missing is to test TauFactor for the cases in between as well, for instance against some idealized shapes with known tortuosity factors (like slanted channels, etc.).

@stke9
Copy link
Contributor

stke9 commented Jun 29, 2023

Added slanted channel to the tests

@stke9 stke9 closed this as completed Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants