JOSS review: Tortuosity factor should always be greater than 1?

[ma-sadeghi]

In of of the unit tests, tortuosity factor is less than 1. I was under the impression that tortuosity should always be greater than 1. Could you please explain?

taufactor/tests/test_taufactor.py

Lines 318 to 328 in abd2877

	def test_taue_deadend():
	"""Run solver on a strip of ones, 1/4 volume of total"""
	l = 100
	img = np.zeros((l, l))
	img[:75, 45:55] = 1
	img[img != 1] = 0
	esolver = tau.ElectrodeSolver(img, device=pt.device('cpu'))
	esolver.solve()
	assert np.around(esolver.tau_e, 3) == 0.601

[stke9]

taue, electrode tortuosity, is not always greater than 1, please see https://www.nature.com/articles/s41524-020-00386-4. Thanks!

[LDXu93]

I submitted a similar issue at #76 last week, according to the npj paper, $tau$, not $tau_e$, should be infinity for a single dead end pore, right? but I got some number smaller than 1.

[stke9]

Hi Lex, I'm working on your issue right now (it's a problem that arose when we changed the convergence criteria), sorry have been waiting for reviews to come back!