Skip to content

"Less than target uncertainty" wrong when changing the target from 5% #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
amirDahari1 opened this issue Sep 4, 2024 · 3 comments
Labels
bug Something isn't working website frontend web-app

Comments

@amirDahari1
Copy link
Member

image
@amirDahari1 amirDahari1 added bug Something isn't working website frontend web-app labels Sep 4, 2024
@rmdocherty
Copy link
Collaborator

what image does this appear for? i'm struggling to reproduce

@rmdocherty
Copy link
Collaborator

Found the image and the problem: to display this 'success' notification I check if the side length is < required side length as returned by model - note I check the length of the first dimension only. For non-square/non-cube images, i.e something with shape (364, 500, 500), if the L target is, say, 464 i.e (464, 464, 464), then 364 < 464 -> success notification.

To fix I either need to always check the smallest dimension in the image, or explicitly check if the percent error returned by model < percent error specified by user

@amirDahari1
Copy link
Member Author

I see, this makes sense! what did you choose?

@amirDahari1 amirDahari1 mentioned this issue Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working website frontend web-app
Projects
None yet
Development

No branches or pull requests

2 participants