Add icons. Possibly fix bug where if you don't rotate the camera before

taking the picture, it gets a landscape orientation by default.

Author: tlau

gen/org/cygx1/snap/R.java

@@ -12,7 +12,8 @@ public static final class attr {
     }
     public static final class drawable {
         public static final int icon=0x7f020000;
-        public static final int stat_sys_warning=0x7f020001;
+        public static final int notify_success=0x7f020001;
+        public static final int stat_sys_warning=0x7f020002;
     }
     public static final class layout {
         public static final int main=0x7f030000;

res/drawable-hdpi/icon.png

@@ -15,7 +15,7 @@ public class Preview extends SurfaceView implements SurfaceHolder.Callback {
 	SurfaceHolder mHolder;
     Camera mCamera;
 	private OrientationEventListener mOrientationListener;
-    private int mLastOrientation, mLastLatchedOrientation = 0;
+    private int mLastLatchedOrientation = -1;
 
     Preview(Context context) {
         super(context);
@@ -28,16 +28,11 @@ public class Preview extends SurfaceView implements SurfaceHolder.Callback {
 
         mOrientationListener = new OrientationEventListener(context) {
 			public void onOrientationChanged(int orientation) {
-				if (null == mCamera) return;
-				
-                // We keep the last known orientation. So if the user
-                // first orient the camera then point the camera to
-                // floor/sky, we still have the correct orientation.
+                // Keep the last known orientation
                 if (orientation != ORIENTATION_UNKNOWN) {
-                    mLastOrientation = orientation;
 
                     int latchedOrientation = roundOrientation(orientation);
-                    if (mLastLatchedOrientation != latchedOrientation) {
+                    if ((null != mCamera) && (mLastLatchedOrientation != latchedOrientation)) {
                         Camera.Parameters parameters = mCamera.getParameters();
                         Log.d("Snap", "Detecting rotation as " + latchedOrientation);
                         parameters.setRotation((latchedOrientation+90)%360);

res/drawable-ldpi/icon.png

@@ -47,12 +47,15 @@
  * detect camera orientation and tag the JPEG with the right orientation (done?)
  * make sure camera preview works on all devices (done?)
  * delete the image after sending
- * design an icon for the app and for the notification
+ * silence the shutter
+ * on error, have the notification take you to the unsent file so you can try again
+ * handle onPause and onResume because I think lack of this causes the camera to get wedged
  * 
  * DONE:
  * send mail from a separate thread so it doesn't block the UI
  * prompt for preferences on startup if they're not set
  * put a unique identifier in the mail subject so it doesn't continue the same gmail thread
+ * design an icon for the app and for the notification
  */
 
 public class Snap extends Activity {
@@ -90,7 +93,7 @@ public void onCreate(Bundle savedInstanceState) {
 		notifyError = new Notification(R.drawable.stat_sys_warning, "", System.currentTimeMillis());
 		notifyError.setLatestEventInfo( context, "Snap", "Unable to send photo", contentIntent);
 		// TODO: better success icon
-		notifySuccess = new Notification(R.drawable.stat_sys_warning, "", System.currentTimeMillis());
+		notifySuccess = new Notification(R.drawable.notify_success, "", System.currentTimeMillis());
 		notifySuccess.setLatestEventInfo( context, "Snap", "Photo sent successfully", contentIntent);
 
 		// TL: the code below tries to invoke the built-in camera app