Added --enable_assertions to pcal translate script

Signed-off-by: Andrew Helwer <[email protected]>

Author: ahelwer

.github/scripts/translate_pluscal.py

@@ -17,6 +17,7 @@
 parser.add_argument('--skip', nargs='+', help='Space-separated list of .tla modules to skip converting', required=False, default=[])
 parser.add_argument('--only', nargs='+', help='If provided, only convert models in this space-separated list', required=False, default=[])
 parser.add_argument('--verbose', help='Set logging output level to debug', action='store_true')
+parser.add_argument('--enable_assertions', help='Enable Java assertions (pass -enableassertions to JVM)', action='store_true')
 args = parser.parse_args()
 
 logging.basicConfig(level = logging.DEBUG if args.verbose else logging.INFO)
@@ -26,6 +27,7 @@
 examples_root = dirname(manifest_path)
 skip_modules = args.skip
 only_modules = args.only
+enable_assertions = args.enable_assertions
 
 manifest = tla_utils.load_json(manifest_path)
 
@@ -44,23 +46,21 @@
 
 def translate_module(module_path):
     logging.info(f'Translating {module_path}')
-    result = subprocess.run(
-        ['java', '-cp', tools_path, 'pcal.trans', '-nocfg', module_path],
+    jvm_parameters = ['-cp', tools_path] + (['-enableassertions'] if enable_assertions else [])
+    pcal_parameters = ['-nocfg', module_path]
+    pcal = subprocess.run(
+        ['java'] + jvm_parameters + ['pcal.trans'] + pcal_parameters,
         stdout=subprocess.PIPE,
         stderr=subprocess.STDOUT,
         text=True
     )
-    match result:
-        case CompletedProcess():
-            if result.returncode == 0:
-                logging.debug(result.stdout)
-                return True
-            else:
-                logging.error(f'Module {module_path} conversion failed with return code {result.returncode}; output:\n{result.stdout}')
-                return False
-        case _:
-            logging.error(f'Unhandled result type {type(result)}: {result.stdout}')
-            return False
+    output = ' '.join(pcal.args) + '\n' + pcal.stdout
+    if 0 == pcal.returncode:
+        logging.debug(output)
+        return True
+    else:
+        logging.error(output)
+        return False
 
 success = True
 thread_count = cpu_count() if not args.verbose else 1