Skip to content

Commit 5b899e9

Browse files
committed
bgpd: changing graceful-restart parameters should not be considered as error
vtysh will return an informational message to the user that changing any graceful-shutdown related parameter will require a peer reset. This is should not be treated as an error message (resulting in a return code of 1) but rather as a simple information to the user. This fixes GitHub issue FRRouting/frr#8403 $ vtysh -c configure -c 'router bgp 100' -c 'bgp graceful-restart' Graceful restart configuration changed, reset all peers to take effect $ echo $? 0 Signed-off-by: Christian Poessinger <[email protected]>
1 parent bc79672 commit 5b899e9

File tree

1 file changed

+0
-3
lines changed

1 file changed

+0
-3
lines changed

bgpd/bgp_vty.c

-3
Original file line numberDiff line numberDiff line change
@@ -840,9 +840,6 @@ int bgp_vty_return(struct vty *vty, int ret)
840840
case BGP_ERR_GR_OPERATION_FAILED:
841841
str = "The Graceful Restart Operation failed due to an err.";
842842
break;
843-
case BGP_GR_NO_OPERATION:
844-
str = GR_NO_OPER;
845-
break;
846843
}
847844
if (str) {
848845
vty_out(vty, "%% %s\n", str);

0 commit comments

Comments
 (0)