Skip to content

Commit 10d52ac

Browse files
authored
Merge pull request #8671 from donaldsharp/pim_possible_crash
Pim possible crash
2 parents 99447cf + 8c70a46 commit 10d52ac

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

pimd/pim_igmp.c

+2-2
Original file line numberDiff line numberDiff line change
@@ -1028,8 +1028,8 @@ struct igmp_sock *pim_igmp_sock_add(struct list *igmp_sock_list,
10281028
sin.sin_addr = ifaddr;
10291029
sin.sin_port = 0;
10301030
if (bind(fd, (struct sockaddr *) &sin, sizeof(sin)) != 0) {
1031-
zlog_warn("Could not bind IGMP socket for %pI4 on %s",
1032-
&ifaddr, ifp->name);
1031+
zlog_warn("Could not bind IGMP socket for %pI4 on %s: %s(%d)",
1032+
&ifaddr, ifp->name, strerror(errno), errno);
10331033
close(fd);
10341034

10351035
return NULL;

pimd/pim_oil.c

+5-3
Original file line numberDiff line numberDiff line change
@@ -426,9 +426,11 @@ static void pim_channel_update_mute(struct channel_oil *c_oil)
426426
struct pim_interface *pim_reg_ifp;
427427
struct pim_interface *vxlan_ifp;
428428

429-
pim_reg_ifp = c_oil->pim->regiface->info;
430-
if (pim_reg_ifp)
431-
pim_channel_update_oif_mute(c_oil, pim_reg_ifp);
429+
if (c_oil->pim->regiface) {
430+
pim_reg_ifp = c_oil->pim->regiface->info;
431+
if (pim_reg_ifp)
432+
pim_channel_update_oif_mute(c_oil, pim_reg_ifp);
433+
}
432434
vxlan_ifp = pim_vxlan_get_term_ifp(c_oil->pim);
433435
if (vxlan_ifp)
434436
pim_channel_update_oif_mute(c_oil, vxlan_ifp);

0 commit comments

Comments
 (0)