Skip to content

Commit f893741

Browse files
author
Budnikov Vyacheslav
committed
v1.3.10
Креш при сканировании карты #17
1 parent 25778a7 commit f893741

File tree

9 files changed

+23
-28
lines changed

9 files changed

+23
-28
lines changed

ASDKCore.podspec

+1-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
Pod::Spec.new do |s|
1010

1111
s.name = "ASDKCore"
12-
s.version = "1.3.9"
12+
s.version = "1.3.10"
1313
s.summary = "Core library that allows you to use internet acquiring from Tinkoff Bank in your app"
1414
s.description = "Core library that allows you to use internet acquiring from Tinkoff Bank in your app!"
1515

ASDKCore/Info.plist

+1-1
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
<key>CFBundlePackageType</key>
1616
<string>FMWK</string>
1717
<key>CFBundleShortVersionString</key>
18-
<string>1.3.9</string>
18+
<string>1.3.10</string>
1919
<key>CFBundleSignature</key>
2020
<string>????</string>
2121
<key>CFBundleVersion</key>

ASDKUI.podspec

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
Pod::Spec.new do |s|
22
s.name = "ASDKUI"
3-
s.version = "1.3.9"
3+
s.version = "1.3.10"
44
s.summary = "UI components library for internet acquiring from Tinkoff Bank"
55
s.description = "UI components library for internet acquiring from Tinkoff Bank!"
66
s.homepage = "https://www.tinkoff.ru"

ASDKUI/Info.plist

+1-1
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
<key>CFBundlePackageType</key>
1616
<string>FMWK</string>
1717
<key>CFBundleShortVersionString</key>
18-
<string>1.3.9</string>
18+
<string>1.3.10</string>
1919
<key>CFBundleSignature</key>
2020
<string>????</string>
2121
<key>CFBundleVersion</key>

ASDKUI/Payment/ASDKAttachCardViewController.m

+2-5
Original file line numberDiff line numberDiff line change
@@ -644,15 +644,12 @@ - (void)scanCard
644644
{
645645
__weak typeof(self) weakSelf = self;
646646

647-
[cardScanner scanCardSuccess:^(id<ASDKAcquiringSdkCardRequisites> cardRequisites)
648-
{
649-
NSLog(@"scanned number %@, ecpired date %@", [cardRequisites number], [cardRequisites expireDate]);
650-
647+
[cardScanner scanCardSuccess:^(id<ASDKAcquiringSdkCardRequisites> cardRequisites){
651648
__strong typeof(weakSelf) strongSelf = weakSelf;
652649

653650
if (strongSelf)
654651
{
655-
[strongSelf updateCardRequisitesCellWithCardRequisites:[cardRequisites number] expiredData:[cardRequisites expireDate]];
652+
[strongSelf updateCardRequisitesCellWithCardRequisites:[cardRequisites cardNumber] expiredData:[cardRequisites cardExpireDate]];
656653
}
657654
}
658655
failure:nil

ASDKUI/Payment/PaymentFormStarter/ASDKPaymentFormStarter.h

+2-2
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,8 @@
2525

2626
@protocol ASDKAcquiringSdkCardRequisites <NSObject>
2727

28-
- (NSString*)number;
29-
- (NSString*)expireDate;
28+
- (NSString*)cardNumber;
29+
- (NSString*)cardExpireDate;
3030

3131
@end
3232

ASDKUI/Payment/PaymentViewController/ASDKPaymentFormViewController.m

+4-7
Original file line numberDiff line numberDiff line change
@@ -901,15 +901,12 @@ - (void)scanCard
901901
{
902902
__weak typeof(self) weakSelf = self;
903903

904-
[cardScanner scanCardSuccess:^(id<ASDKAcquiringSdkCardRequisites> cardRequisites)
905-
{
906-
NSLog(@"scanned number %@, ecpired date %@", [cardRequisites number], [cardRequisites expireDate]);
907-
908-
__strong typeof(weakSelf) strongSelf = weakSelf;
909-
904+
[cardScanner scanCardSuccess:^(id<ASDKAcquiringSdkCardRequisites> cardRequisites) {
905+
__strong typeof(weakSelf) strongSelf = weakSelf;
906+
910907
if (strongSelf)
911908
{
912-
[strongSelf updateCardRequisitesCellWithCardRequisites:cardRequisites.number expiredData:cardRequisites.expireDate];
909+
[strongSelf updateCardRequisitesCellWithCardRequisites:cardRequisites.cardNumber expiredData:cardRequisites.cardExpireDate];
913910
}
914911
}
915912
failure:nil

SampleProject/ASDKSampleApp/Source/ASDKCardIOScanner.m

+9-8
Original file line numberDiff line numberDiff line change
@@ -12,19 +12,19 @@
1212

1313
@interface ASDKCardRequisites: NSObject <ASDKAcquiringSdkCardRequisites>
1414

15-
@property (nonatomic, strong) NSString *scanedCardNumber;
16-
@property (nonatomic, strong) NSString *scanedCardExpiredDate;
15+
@property (nonatomic, copy) NSString *scanedCardNumber;
16+
@property (nonatomic, copy) NSString *scanedCardExpiredDate;
1717

1818
@end
1919

2020
@implementation ASDKCardRequisites
2121

22-
- (NSString *)expireDate
22+
- (NSString *)cardExpireDate
2323
{
2424
return self.scanedCardExpiredDate;
2525
}
2626

27-
- (NSString *)number
27+
- (NSString *)cardNumber
2828
{
2929
return self.scanedCardNumber;
3030
}
@@ -33,6 +33,7 @@ - (NSString *)number
3333

3434
@interface ASDKCardIOScanner () <CardIOPaymentViewControllerDelegate>
3535

36+
@property (nonatomic, strong) ASDKCardRequisites *cardRequisites;
3637
@property (nonatomic, strong) void (^successBlock)(id<ASDKAcquiringSdkCardRequisites> cardRequisites);
3738
@property (nonatomic, strong) void (^cancelBlock)(void);
3839

@@ -98,14 +99,14 @@ - (void)userDidProvideCreditCardInfo:(CardIOCreditCardInfo *)info inPaymentViewC
9899
{
99100
if (self.successBlock)
100101
{
101-
ASDKCardRequisites *cardRequisites = [[ASDKCardRequisites alloc] init];
102-
cardRequisites.scanedCardNumber = info.cardNumber;
102+
self.cardRequisites = [[ASDKCardRequisites alloc] init];
103+
self.cardRequisites.scanedCardNumber = info.cardNumber;
103104
if (info.expiryYear > 0 && info.expiryMonth > 0)
104105
{
105-
cardRequisites.scanedCardExpiredDate = [NSString stringWithFormat:@"%02lu/%02lu", (unsigned long)info.expiryMonth, (unsigned long)(info.expiryYear - 2000)];
106+
self.cardRequisites.scanedCardExpiredDate = [NSString stringWithFormat:@"%02lu/%02lu", (unsigned long)info.expiryMonth, (unsigned long)(info.expiryYear - 2000)];
106107
}
107108

108-
self.successBlock(cardRequisites);
109+
self.successBlock(self.cardRequisites);
109110
}
110111

111112
[self closePaymentViewController:paymentViewController];

SampleProject/ASDKSampleApp/Supporting files/Info.plist

+2-2
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,11 @@
1515
<key>CFBundlePackageType</key>
1616
<string>APPL</string>
1717
<key>CFBundleShortVersionString</key>
18-
<string>1.3.9</string>
18+
<string>1.3.10</string>
1919
<key>CFBundleSignature</key>
2020
<string>????</string>
2121
<key>CFBundleVersion</key>
22-
<string>61</string>
22+
<string>62</string>
2323
<key>LSRequiresIPhoneOS</key>
2424
<true/>
2525
<key>NSAppTransportSecurity</key>

0 commit comments

Comments
 (0)