Merge branch 'pu/pm/CoursesDivisImportTeacherUsernameCmpFixed' into '2024.11'

paulmhh · paulmhh · commit 59a364d4ad2d · 2025-06-17T09:08:41.000Z
tweak(Courses) fix teacher username temp generation

See merge request tine20/tine20!7185
diff --git a/tine20/Courses/Import/DivisCourses.php b/tine20/Courses/Import/DivisCourses.php
@@ -855,7 +855,12 @@ protected function _skipAccount(Tinebase_Model_FullUser $account): bool
 
     protected function _getLehrerUserName(array $raw): string
     {
-        return strtolower(substr($raw[0], 0, 1) . '.' . $raw[1]);
+        $tmp = new Tinebase_Model_FullUser([
+            'accountFirstName' => $raw[0],
+            'accountLastName' => $raw[1],
+        ], true);
+        $tmp->applyTwigTemplates();
+        return $tmp->shortenUsername();
     }
 
     protected function _getRawData(&$_resource)

Original file line number	Diff line number	Diff line change
`@@ -855,7 +855,12 @@ protected function _skipAccount(Tinebase_Model_FullUser $account): bool`
`855`	`855`
`856`	`856`	`protected function _getLehrerUserName(array $raw): string`
`857`	`857`	`{`
`858`		`- return strtolower(substr($raw[0], 0, 1) . '.' . $raw[1]);`
	`858`	`+ $tmp = new Tinebase_Model_FullUser([`
	`859`	`+ 'accountFirstName' => $raw[0],`
	`860`	`+ 'accountLastName' => $raw[1],`
	`861`	`+ ], true);`
	`862`	`+ $tmp->applyTwigTemplates();`
	`863`	`+ return $tmp->shortenUsername();`
`859`	`864`	`}`
`860`	`865`
`861`	`866`	`protected function _getRawData(&$_resource)`