Merge remote-tracking branch 'origin/2023.11' into 2024.11

Author: paulmhh

tests/tine20/Filemanager/Frontend/WebDAVTest.php

@@ -1318,7 +1318,7 @@ public function testCreateFile()
     {
         $parent = $this->testgetNodeForPath_webdav_filemanager_shared_unittestdirectory();
         $rc = fopen('php://temp', 'r');
-        $etag = $parent->createFile('AR-0394xa5 => GS-00sb064', $rc);
+        $etag = $parent->createFile('AR-0394xa5 = GS-00sb064', $rc);
         fclose($rc);
         self::assertRegExp('/"[a-z0-9]+"/', $etag);
     }

tine20/Filemanager/js/NodeTreePanel.js

@@ -364,7 +364,7 @@ Tine.Filemanager.NodeTreePanel = Ext.extend(Tine.widgets.container.TreePanel, {
                     }
 
                     if (!Tine.Filemanager.Model.Node.isNameValid(text)) {
-                        Ext.Msg.alert(String.format(this.app.i18n._('No {0} added'), nodeName), this.app.i18n._('Illegal characters: ') + forbidden);
+                        Ext.Msg.alert(String.format(this.app.i18n._('No {0} added'), nodeName), this.app.i18n._('Illegal characters: ') + text);
                         return;
                     }
 

tine20/Tinebase/Frontend/WebDAV/Node.php

@@ -165,6 +165,8 @@ public static function checkForbiddenFile($name)
             throw new Tine20\DAV\Exception\Forbidden('forbidden name');
         } else if (substr($name, 0, 2) == '._') {
             throw new Tine20\DAV\Exception\Forbidden('no resource files accepted');
+        } else if (preg_match(Tinebase_Model_Tree_Node::FILENAME_FORBIDDEN_CHARS_EXP, $name, $matches)) {
+            throw new Tine20\DAV\Exception\Forbidden('Illegal characters: ' . print_r($matches, true));
         }
     }