Allow SET NOT NULL on column of compressed table #7463
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkindahl
force-pushed
the
compressed-alter-column-set-not-null
branch
from
da099bd to
8449949
Compare
mkindahl
force-pushed
the
compressed-alter-column-set-not-null
branch
from
8449949 to
71c08e1
Compare
mkindahl
force-pushed
the
compressed-alter-column-set-not-null
branch
from
71c08e1 to
8eb4f4e
Compare
mkindahl
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7463 +/- ##
==========================================
+ Coverage 80.06% 82.11% +2.04%
==========================================
Files 190 230 +40
Lines 37181 43104 +5923
Branches 9450 10834 +1384
==========================================
+ Hits 29770 35395 +5625
- Misses 2997 3397 +400
+ Partials 4414 4312 -102 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
erimatnor
reviewed
Nov 20, 2024
erimatnor
reviewed
Nov 20, 2024
mkindahl
force-pushed
the
compressed-alter-column-set-not-null
branch
from
7a0ebc1 to
8caf04c
Compare
erimatnor
reviewed
Nov 20, 2024
erimatnor
reviewed
Nov 20, 2024
erimatnor
reviewed
Nov 20, 2024
erimatnor
approved these changes
Nov 20, 2024
mkindahl
force-pushed
the
compressed-alter-column-set-not-null
branch
from
8caf04c to
6799243
Compare
mkindahl
force-pushed
the
compressed-alter-column-set-not-null
branch
2 times, most recently
from
05d1e56 to
0b52822
Compare
fabriziomello
approved these changes
Nov 20, 2024
mkindahl
force-pushed
the
compressed-alter-column-set-not-null
branch
from
0b52822 to
51c50c3
Compare
Since `SET NOT NULL` will only do a full table scan of the table to verify that there are no nulls, this should work without having to modify any data in the table. However, it does not work for chunks using the `heap` table access method if they are compressed since it uses a normal table scan, so adding a check for this.
mkindahl
force-pushed
the
compressed-alter-column-set-not-null
branch
from
51c50c3 to
9fe71d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
SET NOT NULLwill only do a full table scan of the table to verify that there are no nulls, this should work without having to modify any data in the table. However, since the command does atable_beginscanit does not work for hypertables with compressed chunks that uses theheaptable access method.Disable-check: force-changelog-file