Support ALTER TABLE SET (tsdb.chunk_time_interval='1 day')

Author: svenklemm

src/process_utility.c

@@ -3745,9 +3745,11 @@ process_create_table_end(Node *parsetree)
 			AttrNumber time_attno = get_attnum(table_relid, time_column);
 			Oid time_type = get_atttype(table_relid, time_attno);
 
-			interval = ts_create_table_parse_chunk_time_interval(create_table_info.with_clauses,
-																 time_type,
-																 &interval_type);
+			interval =
+				ts_create_table_parse_chunk_time_interval(create_table_info.with_clauses
+															  [CreateTableFlagChunkTimeInterval],
+														  time_type,
+														  &interval_type);
 		}
 
 		if (!create_table_info.with_clauses[CreateTableFlagCreateDefaultIndexes].is_default)
@@ -4925,7 +4927,28 @@ process_altertable_set_options(AlterTableCmd *cmd, Hypertable *ht)
 
 	parse_results = ts_alter_table_with_clause_parse(compress_options);
 
-	ts_cm_functions->process_compress_table(ht, parse_results);
+	if (ht && !parse_results[AlterTableFlagChunkTimeInterval].is_default)
+	{
+		Dimension *dim = ts_hyperspace_get_mutable_dimension(ht->space, DIMENSION_TYPE_OPEN, 0);
+		Ensure(dim, "hypertable without open dimension");
+		Oid time_type = get_atttype(dim->main_table_relid, dim->column_attno);
+		Oid interval_type = InvalidOid;
+		Datum interval =
+			ts_create_table_parse_chunk_time_interval(parse_results
+														  [AlterTableFlagChunkTimeInterval],
+													  time_type,
+													  &interval_type);
+
+		int64 chunk_interval = ts_interval_value_to_internal(interval, interval_type);
+		ts_dimension_set_chunk_interval(dim, chunk_interval);
+	}
+
+	if (!parse_results[AlterTableFlagCompressEnabled].is_default ||
+		!parse_results[AlterTableFlagCompressOrderBy].is_default ||
+		!parse_results[AlterTableFlagCompressSegmentBy].is_default ||
+		!parse_results[AlterTableFlagCompressChunkTimeInterval].is_default)
+		ts_cm_functions->process_compress_table(ht, parse_results);
+
 	return DDL_DONE;
 }
 

src/with_clause/alter_table_with_clause.c

@@ -24,6 +24,10 @@
 #include "alter_table_with_clause.h"
 
 static const WithClauseDefinition alter_table_with_clause_def[] = {
+		[AlterTableFlagChunkTimeInterval] = {
+			.arg_names = {"chunk_time_interval", NULL},
+			 .type_id = TEXTOID,
+		},
 		[AlterTableFlagCompressEnabled] = {
 			.arg_names = {"compress", "columnstore", "enable_columnstore", NULL},
 			.type_id = BOOLOID,

src/with_clause/alter_table_with_clause.h

@@ -15,7 +15,8 @@
 
 typedef enum AlterTableFlags
 {
-	AlterTableFlagCompressEnabled = 0,
+	AlterTableFlagChunkTimeInterval = 0,
+	AlterTableFlagCompressEnabled,
 	AlterTableFlagCompressSegmentBy,
 	AlterTableFlagCompressOrderBy,
 	AlterTableFlagCompressChunkTimeInterval,

src/with_clause/create_materialized_view_with_clause.c

@@ -79,6 +79,9 @@ ts_continuous_agg_get_compression_defelems(const WithClauseResult *with_clauses)
 		int option_index = 0;
 		switch (i)
 		{
+			case AlterTableFlagChunkTimeInterval:
+				continue;
+				break;
 			case AlterTableFlagCompressEnabled:
 				option_index = CreateMaterializedViewFlagCompress;
 				break;

src/with_clause/create_table_with_clause.c

@@ -30,12 +30,12 @@ ts_create_table_with_clause_parse(const List *defelems)
 }
 
 Datum
-ts_create_table_parse_chunk_time_interval(WithClauseResult *parsed_options, Oid column_type,
+ts_create_table_parse_chunk_time_interval(WithClauseResult option, Oid column_type,
 										  Oid *interval_type)
 {
-	if (parsed_options[CreateTableFlagChunkTimeInterval].is_default == false)
+	if (option.is_default == false)
 	{
-		Datum textarg = parsed_options[CreateTableFlagChunkTimeInterval].parsed;
+		Datum textarg = option.parsed;
 		switch (column_type)
 		{
 			case INT2OID:

src/with_clause/create_table_with_clause.h

@@ -21,5 +21,5 @@ typedef enum CreateTableFlags
 
 WithClauseResult *ts_create_table_with_clause_parse(const List *defelems);
 
-Datum ts_create_table_parse_chunk_time_interval(WithClauseResult *parsed_options, Oid column_type,
+Datum ts_create_table_parse_chunk_time_interval(WithClauseResult parsed_options, Oid column_type,
 												Oid *interval_type);

test/expected/create_chunks.out

@@ -292,3 +292,18 @@ SELECT count(*) FROM test_output;
      2
 (1 row)
 
+-- test ALTER TABLE SET (tsdb.chunk_time_interval) on a hypertable
+CREATE TABLE t_with(time timestamptz not null, device text, value float) WITH (tsdb.hypertable,tsdb.time_column='time');
+SELECT time_interval FROM timescaledb_information.dimensions WHERE hypertable_name = 't_with';
+ time_interval 
+---------------
+ @ 7 days
+(1 row)
+
+ALTER TABLE t_with SET (tsdb.chunk_time_interval = '1 hour');
+SELECT time_interval FROM timescaledb_information.dimensions WHERE hypertable_name = 't_with';
+ time_interval 
+---------------
+ @ 1 hour
+(1 row)
+

test/sql/create_chunks.sql

@@ -171,3 +171,12 @@ SELECT relname, relreplident FROM show_chunks('test_ht') ch JOIN pg_class c ON (
 SELECT count(*) FROM test_tb;
 SELECT count(*) FROM test_ht;
 SELECT count(*) FROM test_output;
+
+-- test ALTER TABLE SET (tsdb.chunk_time_interval) on a hypertable
+CREATE TABLE t_with(time timestamptz not null, device text, value float) WITH (tsdb.hypertable,tsdb.time_column='time');
+
+SELECT time_interval FROM timescaledb_information.dimensions WHERE hypertable_name = 't_with';
+ALTER TABLE t_with SET (tsdb.chunk_time_interval = '1 hour');
+SELECT time_interval FROM timescaledb_information.dimensions WHERE hypertable_name = 't_with';
+
+