Do not use ERRCODE_INTERNAL_ERROR for user errors

This code is reserved for internal program errors, i.e. bugs. This
commit fixes only some of these existing incorrect codes, we have more.

Author: Poroma-Banerjee

src/chunk_adaptive.c

@@ -433,14 +433,18 @@ ts_calculate_chunk_interval(PG_FUNCTION_ARGS)
 		elog(ERROR, "invalid number of arguments");
 
 	if (chunk_target_size_bytes < 0)
-		elog(ERROR, "chunk_target_size must be positive");
+		ereport(ERROR,
+				(errcode(ERRCODE_INVALID_PARAMETER_VALUE),
+				 errmsg("chunk_target_size must be positive")));
 
 	elog(DEBUG1, "[adaptive] chunk_target_size_bytes=" UINT64_FORMAT, chunk_target_size_bytes);
 
 	hypertable_id = ts_dimension_get_hypertable_id(dimension_id);
 
 	if (hypertable_id <= 0)
-		elog(ERROR, "could not find a matching hypertable for dimension %u", dimension_id);
+		ereport(ERROR,
+				(errcode(ERRCODE_UNDEFINED_OBJECT),
+				 errmsg("could not find a matching hypertable for dimension %u", dimension_id)));
 
 	ht = ts_hypertable_get_by_id(hypertable_id);
 
@@ -830,7 +834,7 @@ ChunkSizingInfo *
 ts_chunk_sizing_info_get_default_disabled(Oid table_relid)
 {
 	ChunkSizingInfo *chunk_sizing_info = palloc(sizeof(*chunk_sizing_info));
-	*chunk_sizing_info = (ChunkSizingInfo){
+	*chunk_sizing_info = (ChunkSizingInfo) {
 		.table_relid = table_relid,
 		.target_size = NULL,
 		.func = get_default_chunk_sizing_fn_oid(),

tsl/src/compression/create.c

@@ -310,9 +310,10 @@ build_columndefs(CompressionSettings *settings, Oid src_reloid)
 		if (strncmp(NameStr(attr->attname),
 					COMPRESSION_COLUMN_METADATA_PREFIX,
 					strlen(COMPRESSION_COLUMN_METADATA_PREFIX)) == 0)
-			elog(ERROR,
-				 "cannot compress tables with reserved column prefix '%s'",
-				 COMPRESSION_COLUMN_METADATA_PREFIX);
+			ereport(ERROR,
+					(errcode(ERRCODE_RESERVED_NAME),
+					 errmsg("cannot convert tables with reserved column prefix '%s'",
+							COMPRESSION_COLUMN_METADATA_PREFIX)));
 
 		bool is_segmentby = ts_array_is_member(segmentby, NameStr(attr->attname));
 		if (is_segmentby)
@@ -466,9 +467,10 @@ build_columndef_singlecolumn(const char *colname, Oid typid)
 	if (strncmp(colname,
 				COMPRESSION_COLUMN_METADATA_PREFIX,
 				strlen(COMPRESSION_COLUMN_METADATA_PREFIX)) == 0)
-		elog(ERROR,
-			 "cannot compress tables with reserved column prefix '%s'",
-			 COMPRESSION_COLUMN_METADATA_PREFIX);
+		ereport(ERROR,
+				(errcode(ERRCODE_RESERVED_NAME),
+				 errmsg("cannot convert tables with reserved column prefix '%s'",
+						COMPRESSION_COLUMN_METADATA_PREFIX)));
 
 	return makeColumnDef(colname, compresseddata_oid, -1 /*typmod*/, 0 /*collation*/);
 }
@@ -1006,9 +1008,10 @@ validate_hypertable_for_compression(Hypertable *ht)
 		if (strncmp(NameStr(attr->attname),
 					COMPRESSION_COLUMN_METADATA_PREFIX,
 					strlen(COMPRESSION_COLUMN_METADATA_PREFIX)) == 0)
-			elog(ERROR,
-				 "cannot convert tables with reserved column prefix '%s' to columnstore",
-				 COMPRESSION_COLUMN_METADATA_PREFIX);
+			ereport(ERROR,
+					(errcode(ERRCODE_RESERVED_NAME),
+					 errmsg("cannot convert tables with reserved column prefix '%s' to columnstore",
+							COMPRESSION_COLUMN_METADATA_PREFIX)));
 	}
 
 	if (row_size > MaxHeapTupleSize)
@@ -1430,9 +1433,10 @@ tsl_process_compress_table_rename_column(Hypertable *ht, const RenameStmt *stmt)
 	if (strncmp(stmt->newname,
 				COMPRESSION_COLUMN_METADATA_PREFIX,
 				strlen(COMPRESSION_COLUMN_METADATA_PREFIX)) == 0)
-		elog(ERROR,
-			 "cannot convert tables with reserved column prefix '%s' to columnstore",
-			 COMPRESSION_COLUMN_METADATA_PREFIX);
+		ereport(ERROR,
+				(errcode(ERRCODE_RESERVED_NAME),
+				 errmsg("cannot convert tables with reserved column prefix '%s' to columnstore",
+						COMPRESSION_COLUMN_METADATA_PREFIX)));
 
 	if (!TS_HYPERTABLE_HAS_COMPRESSION_TABLE(ht))
 	{