Do not use ERRCODE_INTERNAL_ERROR for user errors

This code is reserved for internal program errors, i.e. bugs. This
commit fixes only some of these existing incorrect codes, we have more.

Author: Poroma-Banerjee

src/chunk_adaptive.c

@@ -440,7 +440,9 @@ ts_calculate_chunk_interval(PG_FUNCTION_ARGS)
 	hypertable_id = ts_dimension_get_hypertable_id(dimension_id);
 
 	if (hypertable_id <= 0)
-		elog(ERROR, "could not find a matching hypertable for dimension %u", dimension_id);
+		ereport(ERROR,
+				(errcode(ERRCODE_INSUFFICIENT_PRIVILEGE),
+				 errmsg("could not find a matching hypertable for dimension %u", dimension_id)));
 
 	ht = ts_hypertable_get_by_id(hypertable_id);
 
@@ -830,7 +832,7 @@ ChunkSizingInfo *
 ts_chunk_sizing_info_get_default_disabled(Oid table_relid)
 {
 	ChunkSizingInfo *chunk_sizing_info = palloc(sizeof(*chunk_sizing_info));
-	*chunk_sizing_info = (ChunkSizingInfo){
+	*chunk_sizing_info = (ChunkSizingInfo) {
 		.table_relid = table_relid,
 		.target_size = NULL,
 		.func = get_default_chunk_sizing_fn_oid(),

tsl/src/compression/create.c

@@ -1006,9 +1006,10 @@ validate_hypertable_for_compression(Hypertable *ht)
 		if (strncmp(NameStr(attr->attname),
 					COMPRESSION_COLUMN_METADATA_PREFIX,
 					strlen(COMPRESSION_COLUMN_METADATA_PREFIX)) == 0)
-			elog(ERROR,
-				 "cannot convert tables with reserved column prefix '%s' to columnstore",
-				 COMPRESSION_COLUMN_METADATA_PREFIX);
+			ereport(ERROR,
+					(errcode(ERRCODE_RESERVED_NAME),
+					 errmsg("cannot convert tables with reserved column prefix '%s' to columnstore",
+							COMPRESSION_COLUMN_METADATA_PREFIX)));
 	}
 
 	if (row_size > MaxHeapTupleSize)
@@ -1192,7 +1193,7 @@ compression_setting_orderby_get_default(Hypertable *ht, ArrayType *segmentby)
 	if (!OidIsValid(orderby_fn))
 	{
 		/* fallback to original logic */
-		OrderBySettings obs = (OrderBySettings){ 0 };
+		OrderBySettings obs = (OrderBySettings) { 0 };
 		obs = add_time_to_order_by_if_not_included(obs, segmentby, ht);
 		elog(LOG_SERVER_ONLY,
 			 "order_by default: hypertable=\"%s\" function=\"\" confidence=-1",