Skip to content

Commit 9e0a4cc

Browse files
committed
fix: compile and CI
1 parent ca8816e commit 9e0a4cc

File tree

5 files changed

+4
-9
lines changed

5 files changed

+4
-9
lines changed

.github/workflows/smoke-test-macos.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,6 @@ jobs:
3838
gsed -i '4i\ <preference name="SwiftVersion" value="5" />' config.xml
3939
cordova platform add android@latest
4040
gsed -i '4i\ <preference name="GradlePluginKotlinEnabled" value="true" />' config.xml
41-
gsed -i '4i\ <preference name="AndroidXEnabled" value="true" />' config.xml
4241
4342
- name: Install Plugins
4443
run: |

.github/workflows/smoke-test-ubuntu-ionic.yml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,13 +31,12 @@ jobs:
3131
npm i -g cordova @ionic/cli
3232
ionic start lottie-smoke-test tabs --cordova --type angular --no-interactive --no-confirm
3333
cd lottie-smoke-test
34-
ionic cordova platform add [email protected] --no-interactive --confirm
34+
ionic cordova platform add android@latest --no-interactive --confirm
35+
sed -i '4i\ <preference name="GradlePluginKotlinEnabled" value="true" />' config.xml
3536
3637
- name: Install Plugins
3738
run: |
3839
cd lottie-smoke-test
39-
ionic cordova plugin add cordova-plugin-androidx --no-interactive --confirm
40-
ionic cordova plugin add cordova-plugin-androidx-adapter --no-interactive --confirm
4140
ionic cordova plugin add $GITHUB_WORKSPACE --no-interactive --confirm -- --link
4241
4342
- name: Build Project

.github/workflows/smoke-test-ubuntu.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,6 @@ jobs:
3333
cd lottie-smoke-test
3434
cordova platform add android@latest
3535
sed -i '4i\ <preference name="GradlePluginKotlinEnabled" value="true" />' config.xml
36-
sed -i '4i\ <preference name="AndroidXEnabled" value="true" />' config.xml
3736
3837
- name: Install Plugins
3938
run: |

.github/workflows/smoke-test-windows.yml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ jobs:
1717

1818
- uses: actions/[email protected]
1919
with:
20-
node-version: '16.x'
20+
node-version: '12.x'
2121

2222
- name: Environment Information
2323
run: |
@@ -35,8 +35,6 @@ jobs:
3535
- name: Install Plugins
3636
run: |
3737
cd lottie-smoke-test
38-
cordova plugin add cordova-plugin-androidx
39-
cordova plugin add cordova-plugin-androidx-adapter
4038
cordova plugin add $env:GITHUB_WORKSPACE --link
4139
4240
- name: Build Project

src/ios/LottieSplashScreen.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -268,7 +268,7 @@ import Lottie
268268
)
269269
}
270270

271-
private func getUIModeDependentPreference(basePreferenceName: String, defaultValue: String? = "") -> String {
271+
private func getUIModeDependentPreference(basePreferenceName: String, defaultValue: String = "") -> String {
272272
var preferenceValue = ""
273273
if #available(iOS 12.0, *) {
274274
if viewController.traitCollection.userInterfaceStyle == .dark {

0 commit comments

Comments
 (0)