minikube: use cluster name to find minikube profile (#6528)

this ensures that if a
user has renamed their kube context,
we still find the right profile.

fixes #6510

Signed-off-by: Nick Santos <[email protected]>

Author: nicks

internal/cli/wire_gen.go

@@ -56,8 +56,8 @@ func KubernetesClientFromEnv(ctx context.Context, contextOverride k8s.KubeContex
 	portForwardClient := k8s.ProvidePortForwardClient(restConfigOrError, clientsetOrError)
 	namespace := k8s.ProvideConfigNamespace(clientConfig)
 	kubeContext := k8s.ProvideKubeContext(apiConfigOrError)
-	minikubeClient := k8s.ProvideMinikubeClient(kubeContext)
 	clusterName := k8s.ProvideClusterName(apiConfigOrError)
+	minikubeClient := k8s.ProvideMinikubeClient(clusterName)
 	client := k8s.ProvideK8sClient(ctx, env, restConfigOrError, clientsetOrError, portForwardClient, kubeContext, clusterName, namespace, minikubeClient, apiConfigOrError, clientConfig)
 	_, err := client.CheckConnected(ctx)
 	if err != nil {

internal/controllers/core/cluster/client.go

@@ -32,10 +32,17 @@ type MinikubeClient interface {
 }
 
 type minikubeClient struct {
-	context KubeContext
+	// The minikube client needs to know which minikube profile to talk to.
+	//
+	// When minikube creates a cluster, it sets the kubeconfig context name and
+	// the cluster nameto the name of the profile.
+	//
+	// The cluster name is better because users
+	// don't usually rename it.
+	context ClusterName
 }
 
-func ProvideMinikubeClient(context KubeContext) MinikubeClient {
+func ProvideMinikubeClient(context ClusterName) MinikubeClient {
 	return minikubeClient{context: context}
 }