Fix: Define GPR_ASSERT macro for compatibility #660
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welcome @nikurt! It looks like this is your first PR to tikv/grpc-rs 🎉 |
nikurt
changed the title
Added a fallback definition for GPR_ASSERT using <assert.h> to handle cases where it is not predefined. This ensures smoother compilation and avoids potential issues with missing assertions. Signed-off-by: Nikolay Kurtov <[email protected]> Signed-off-by: Nikolay Kurtov <[email protected]>
BusyJay
reviewed
May 22, 2025
| @@ -66,6 +66,11 @@ | |||
| #define GPR_CALLTYPE | |||
| #endif | |||
|
|
|||
| #ifndef GPR_ASSERT | |||
| #include <assert.h> | |||
There was a problem hiding this comment.
How about switching to absl check just like what upstream did?
There was a problem hiding this comment.
Thanks for the suggestion, haven't thought of that.
Observations:
absl/log/absl_check.hhas a static assert that the C++ variant is at least C++14ABSL_CHECKdepends onusing string_view = std::string_viewwhich is only available in C++17.
Attempted a prototype #661 which upgrades C++ to C++14, but can't make it compile.
A different prototype #662 upgrades C++ to C++17 and it compiles.
Here is what happens with a C++14 upgrade:
% cargo build
Compiling grpcio-sys v0.13.0+1.56.2-patched (/home/nkurtov/code/grpc-rs/grpc-sys)
warning: [email protected]+1.56.2-patched: In file included from /usr/include/absl/log/internal/nullstream.h:37,
warning: [email protected]+1.56.2-patched: from /usr/include/absl/log/internal/check_op.h:40,
warning: [email protected]+1.56.2-patched: from /usr/include/absl/log/internal/check_impl.h:19,
warning: [email protected]+1.56.2-patched: from /usr/include/absl/log/absl_check.h:38,
warning: [email protected]+1.56.2-patched: from grpc_wrap.cc:71:
warning: [email protected]+1.56.2-patched: /usr/include/absl/strings/string_view.h:53:26: error: 'string_view' in namespace 'std' does not name a type
warning: [email protected]+1.56.2-patched: 53 | using string_view = std::string_view;
warning: [email protected]+1.56.2-patched: | ^~~~~~~~~~~
warning: [email protected]+1.56.2-patched: /usr/include/absl/strings/string_view.h:53:21: note: 'std::string_view' is only available from C++17 onwards
warning: [email protected]+1.56.2-patched: 53 | using string_view = std::string_view;
warning: [email protected]+1.56.2-patched: | ^~~
There was a problem hiding this comment.
I see. Upgrading C++ standard will introduce breaking change, let's keep it this way for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a fallback definition for GPR_ASSERT using <assert.h> to handle cases where it is not predefined. This ensures smoother compilation and avoids potential issues with missing assertions.
Fixes #659