fix: restart otaclient when client update is failed (#576)

Author: airkei

src/otaclient/ota_core.py

@@ -1208,9 +1208,9 @@ def client_update(self, request: ClientUpdateRequestV2) -> None:
             ).execute()
         except ota_errors.OTAError:
             # TODO(airkei) [2025-06-19]: should return the dedicated error code for "client update"
-            self._exit_from_dynamic_client()
+            self._client_update_control_flags.request_shutdown_event.set()
         except Exception:
-            self._exit_from_dynamic_client()
+            self._client_update_control_flags.request_shutdown_event.set()
 
     def rollback(self, request: RollbackRequestV2) -> None:
         self._live_ota_status = OTAStatus.ROLLBACKING

tests/test_otaclient/test_ota_core.py

@@ -268,15 +268,14 @@ def test_client_update_interrupted(self, mocker: pytest_mock.MockerFixture):
         """Test client update with interruption."""
         from otaclient._types import ClientUpdateRequestV2
 
-        mock_exit_from_dynamic_client = mocker.patch.object(
-            self.ota_client, "_exit_from_dynamic_client"
-        )
-
         # inject exception
         _error = OTAErrorRecoverable(
             "client update interrupted by test as expected", module=__name__
         )
         self.ota_client_updater.execute.side_effect = _error
+        self.ota_client._client_update_control_flags.request_shutdown_event.set = (
+            mocker.MagicMock()
+        )
 
         # --- execution --- #
         self.ota_client.client_update(
@@ -291,8 +290,8 @@ def test_client_update_interrupted(self, mocker: pytest_mock.MockerFixture):
         # --- assertion on interrupted client update --- #
         self.ota_client_updater.execute.assert_called_once()
 
-        # Verify that _exit_from_dynamic_client was called
-        mock_exit_from_dynamic_client.assert_called_once()
+        # Verify that request_shutdown_event was set
+        self.ota_client._client_update_control_flags.request_shutdown_event.set.assert_called_once()
 
 
 class TestOTAClientUpdater: