Better handling of whitespace-only content (#393)

For `chat_claude()` and `chat_bedrock()`.  Fixes #376.

Author: hadley

NEWS.md

@@ -1,5 +1,8 @@
 # ellmer (development version)
 
+* `chat_claude()` and `chat_bedrock()` no longer choke after receiving an 
+  output that consists only of whitespace (#376).
+
 * `live_browser()` now initializes `shinychat::chat_ui()` with the messages from
   the chat turns, rather than replaying the turns server-side (#381).
 

R/provider-bedrock.R

@@ -284,7 +284,11 @@ method(as_json, list(ProviderBedrock, Turn)) <- function(provider, x) {
 }
 
 method(as_json, list(ProviderBedrock, ContentText)) <- function(provider, x) {
-  list(text = x@text)
+  if (is_whitespace(x@text)) {
+    list(text = "[empty string]")
+  } else {
+    list(text = x@text)
+  }
 }
 
 method(as_json, list(ProviderBedrock, ContentImageRemote)) <- function(

R/provider-claude.R

@@ -266,7 +266,11 @@ method(as_json, list(ProviderClaude, Turn)) <- function(provider, x) {
 }
 
 method(as_json, list(ProviderClaude, ContentText)) <- function(provider, x) {
-  list(type = "text", text = x@text)
+  if (is_whitespace(x@text)) {
+    list(type = "text", text = "[empty string]")
+  } else {
+    list(type = "text", text = x@text)
+  }
 }
 
 method(as_json, list(ProviderClaude, ContentPDF)) <- function(provider, x) {

R/utils.R

@@ -128,3 +128,7 @@ modify_list <- function(x, y) {
 
   utils::modifyList(x, y)
 }
+
+is_whitespace <- function(x) {
+  grepl("^(\\s|\n)*$", x)
+}

tests/testthat/test-provider-bedrock.R

@@ -72,6 +72,13 @@ test_that("can use pdfs", {
   test_pdf_local(chat_fun)
 })
 
+# Provider idiosynchronies -----------------------------------------------
+
+test_that("continues to work after whitespace only outputs (#376)", {
+  chat <- chat_bedrock()
+  chat$chat("Respond with only two blank lines")
+  expect_equal(chat$chat("What's 1+1? Just give me the number"), "2")
+})
 
 # Auth --------------------------------------------------------------------
 

tests/testthat/test-provider-claude.R

@@ -62,3 +62,9 @@ test_that("can set beta headers", {
   req <- chat_request(provider)
   expect_equal(req$headers$`anthropic-beta`, c("a", "b"))
 })
+
+test_that("continues to work after whitespace only outputs (#376)", {
+  chat <- chat_claude()
+  chat$chat("Respond with only two blank lines")
+  expect_equal(chat$chat("What's 1+1? Just give me the number"), "2")
+})

tests/testthat/test-utils.R

@@ -10,3 +10,11 @@ test_that("informative error if no key", {
   expect_false(key_exists("FOO"))
   expect_snapshot(key_get("FOO"), error = TRUE)
 })
+
+test_that("detects whitespace", {
+  expect_true(is_whitespace("\n\n\n \t"))
+  expect_true(is_whitespace(""))
+
+  expect_false(is_whitespace("a"))
+  expect_false(is_whitespace("."))
+})