Skip to content

Commit c230c00

Browse files
Jian J Wangmergify[bot]
Jian J Wang
authored andcommitted
SecurityPkg/DxeImageVerificationLib: change IsCertHashFoundInDatabase name (CVE-2019-14575)
IsCertHashFoundInDatabase() is actually used only for searching dbx, according to the function logic, its comments and its use cases. Changing it to IsCertHashFoundInDbx to avoid confusion. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1608 Cc: Jiewen Yao <[email protected]> Cc: Chao Zhang <[email protected]> Signed-off-by: Jian J Wang <[email protected]> Reviewed-by: Jiewen Yao <[email protected]>
1 parent b1c1147 commit c230c00

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

SecurityPkg/Library/DxeImageVerificationLib/DxeImageVerificationLib.c

+3-3
Original file line numberDiff line numberDiff line change
@@ -829,7 +829,7 @@ AddImageExeInfo (
829829
830830
**/
831831
EFI_STATUS
832-
IsCertHashFoundInDatabase (
832+
IsCertHashFoundInDbx (
833833
IN UINT8 *Certificate,
834834
IN UINTN CertSize,
835835
IN EFI_SIGNATURE_LIST *SignatureList,
@@ -1362,7 +1362,7 @@ IsForbiddenByDbx (
13621362
//
13631363
CertPtr = CertPtr + sizeof (UINT32) + CertSize;
13641364

1365-
Status = IsCertHashFoundInDatabase (Cert, CertSize, (EFI_SIGNATURE_LIST *)Data, DataSize, &RevocationTime, &IsFound);
1365+
Status = IsCertHashFoundInDbx (Cert, CertSize, (EFI_SIGNATURE_LIST *)Data, DataSize, &RevocationTime, &IsFound);
13661366
if (EFI_ERROR (Status)) {
13671367
//
13681368
// Error in searching dbx. Consider it as 'found'. RevocationTime might
@@ -1528,7 +1528,7 @@ IsAllowedByDb (
15281528
//
15291529
// Here We still need to check if this RootCert's Hash is revoked
15301530
//
1531-
Status = IsCertHashFoundInDatabase (RootCert, RootCertSize, (EFI_SIGNATURE_LIST *)DbxData, DbxDataSize, &RevocationTime, &IsFound);
1531+
Status = IsCertHashFoundInDbx (RootCert, RootCertSize, (EFI_SIGNATURE_LIST *)DbxData, DbxDataSize, &RevocationTime, &IsFound);
15321532
if (EFI_ERROR (Status)) {
15331533
//
15341534
// Error in searching dbx. Consider it as 'found'. RevocationTime might

0 commit comments

Comments
 (0)