Skip to content

Commit 8372dd0

Browse files
authored
Correctly append new items (#383)
1 parent 1a86b40 commit 8372dd0

File tree

3 files changed

+23
-24
lines changed

3 files changed

+23
-24
lines changed

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@three11/infinite-scroll",
3-
"version": "2.0.0",
3+
"version": "2.0.1",
44
"description": "Infinite scroll: Load more items as you scroll down",
55
"keywords": [
66
"Load more",

src/infinite-scroll.ts

+4-5
Original file line numberDiff line numberDiff line change
@@ -78,10 +78,7 @@ export class InfiniteScroll {
7878
this.next.classList.add(disabledClass);
7979

8080
this.makeRequest(this.next.href, (html: Document) => {
81-
const items = Array.from(html.querySelectorAll(item))
82-
.map(item => item.outerHTML)
83-
.join('');
84-
81+
const items = Array.from(html.querySelectorAll(item));
8582
const nextUrl = html.querySelector(next)?.getAttribute('href') || '';
8683

8784
if (this.next) {
@@ -91,7 +88,9 @@ export class InfiniteScroll {
9188

9289
const container = this.container as HTMLElement;
9390

94-
container.innerHTML += items;
91+
for (const item of items) {
92+
container.appendChild(item);
93+
}
9594

9695
this.isLoading = false;
9796
this.isAtEnd = nextUrl === '';

yarn.lock

+18-18
Original file line numberDiff line numberDiff line change
@@ -518,9 +518,9 @@ fast-levenshtein@^2.0.6:
518518
integrity sha512-DCXu6Ifhqcks7TZKY3Hxp3y6qphY5SJZmrWMDrKcERSOXWQdMhU9Ig/PYrzyw/ul9jOIyh0N4M0tbC5hodg8dw==
519519

520520
fastq@^1.6.0:
521-
version "1.13.0"
522-
resolved "https://registry.yarnpkg.com/fastq/-/fastq-1.13.0.tgz#616760f88a7526bdfc596b7cab8c18938c36b98c"
523-
integrity sha512-YpkpUnK8od0o1hmeSc7UUs/eB/vIPWJYjKck2QKIzAf71Vm1AAQ3EbuZB3g2JIy+pg+ERD0vqI79KyZiB2e2Nw==
521+
version "1.15.0"
522+
resolved "https://registry.yarnpkg.com/fastq/-/fastq-1.15.0.tgz#d04d07c6a2a68fe4599fea8d2e103a937fae6b3a"
523+
integrity sha512-wBrocU2LCXXa+lWBt8RoIRD89Fi8OdABODa/kEnyeyjS5aZO5/GNvI5sEINADqP/h8M29UHTHUb53sUu5Ihqdw==
524524
dependencies:
525525
reusify "^1.0.4"
526526

@@ -601,9 +601,9 @@ glob@^7.1.3:
601601
path-is-absolute "^1.0.0"
602602

603603
glob@^8.0.3:
604-
version "8.0.3"
605-
resolved "https://registry.yarnpkg.com/glob/-/glob-8.0.3.tgz#415c6eb2deed9e502c68fa44a272e6da6eeca42e"
606-
integrity sha512-ull455NHSHI/Y1FqGaaYFaLGkNMMJbavMrEGFXG/PGrg6y7sutWHUHrz6gy6WEBH6akM1M414dWKCNs+IhKdiQ==
604+
version "8.1.0"
605+
resolved "https://registry.yarnpkg.com/glob/-/glob-8.1.0.tgz#d388f656593ef708ee3e34640fdfb99a9fd1c33e"
606+
integrity sha512-r8hpEjiQEYlF2QU0df3dS+nxxSIreXQS1qRhMJM0Q5NDdR386C7jb7Hwwod8Fgiuex+k0GFjgft18yvxm5XoCQ==
607607
dependencies:
608608
fs.realpath "^1.0.0"
609609
inflight "^1.0.4"
@@ -648,9 +648,9 @@ has@^1.0.3:
648648
function-bind "^1.1.1"
649649

650650
ignore@^5.2.0:
651-
version "5.2.1"
652-
resolved "https://registry.yarnpkg.com/ignore/-/ignore-5.2.1.tgz#c2b1f76cb999ede1502f3a226a9310fdfe88d46c"
653-
integrity sha512-d2qQLzTJ9WxQftPAuEQpSPmKqzxePjzVbpAVv62AQ64NTL+wR4JkrVqR/LqFsFEUsHDAiId52mJteHDFuDkElA==
651+
version "5.2.4"
652+
resolved "https://registry.yarnpkg.com/ignore/-/ignore-5.2.4.tgz#a291c0c6178ff1b960befe47fcdec301674a6324"
653+
integrity sha512-MAb38BcSbH0eHNBxn7ql2NH/kX33OkB3lZ1BNdh7ENeRChHTYsTvWrMubiIAMNS2llXEEgZ1MUOBtXChP3kaFQ==
654654

655655
import-fresh@^3.0.0, import-fresh@^3.2.1:
656656
version "3.3.0"
@@ -732,9 +732,9 @@ isexe@^2.0.0:
732732
integrity sha512-RHxMLp9lnKHGHRng9QFhRCMbYAcVpn69smSGcq3f36xjgVVWThj4qqLbTLlq7Ssj8B+fIQ1EuCEGI2lKsyQeIw==
733733

734734
js-sdsl@^4.1.4:
735-
version "4.2.0"
736-
resolved "https://registry.yarnpkg.com/js-sdsl/-/js-sdsl-4.2.0.tgz#278e98b7bea589b8baaf048c20aeb19eb7ad09d0"
737-
integrity sha512-dyBIzQBDkCqCu+0upx25Y2jGdbTGxE9fshMsCdK0ViOongpV+n5tXRcZY9v7CaVQ79AGS9KA1KHtojxiM7aXSQ==
735+
version "4.3.0"
736+
resolved "https://registry.yarnpkg.com/js-sdsl/-/js-sdsl-4.3.0.tgz#aeefe32a451f7af88425b11fdb5f58c90ae1d711"
737+
integrity sha512-mifzlm2+5nZ+lEcLJMoBK0/IH/bDg8XnJfd/Wq6IP+xoCjLZsTOnV2QpxlVbX9bMnkl5PdEjNtBJ9Cj1NjifhQ==
738738

739739
js-yaml@^4.1.0:
740740
version "4.1.0"
@@ -808,9 +808,9 @@ minimatch@^3.0.5, minimatch@^3.1.1, minimatch@^3.1.2:
808808
brace-expansion "^1.1.7"
809809

810810
minimatch@^5.0.1:
811-
version "5.1.0"
812-
resolved "https://registry.yarnpkg.com/minimatch/-/minimatch-5.1.0.tgz#1717b464f4971b144f6aabe8f2d0b8e4511e09c7"
813-
integrity sha512-9TPBGGak4nHfGZsPBohm9AWg6NoT7QTCehS3BIJABslyZbzxfV78QM2Y6+i741OPZIafFAaiiEMh5OyIrJPgtg==
811+
version "5.1.6"
812+
resolved "https://registry.yarnpkg.com/minimatch/-/minimatch-5.1.6.tgz#1cfcb8cf5522ea69952cd2af95ae09477f122a96"
813+
integrity sha512-lKwV/1brpG6mBUFHtb7NUmtABCb2WZZmm2wNiOA5hAb8VdCS4B3dtMWyvcoViccwAW/COERjXLt0zP1zXUN26g==
814814
dependencies:
815815
brace-expansion "^2.0.1"
816816

@@ -905,9 +905,9 @@ prelude-ls@^1.2.1:
905905
integrity sha512-vkcDPrRZo1QZLbn5RLGPpg/WmIQ65qoWWhcGKf/b5eplkkarX0m9z8ppCat4mlOqUsWpyNuYgO3VRyrYHSzX5g==
906906

907907
punycode@^2.1.0:
908-
version "2.1.1"
909-
resolved "https://registry.yarnpkg.com/punycode/-/punycode-2.1.1.tgz#b58b010ac40c22c5657616c8d2c2c02c7bf479ec"
910-
integrity sha512-XRsRjdf+j5ml+y/6GKHPZbrF/8p2Yga0JPtdqTIY2Xe5ohJPD9saDJJLPvp9+NSBprVvevdXZybnj2cv8OEd0A==
908+
version "2.3.0"
909+
resolved "https://registry.yarnpkg.com/punycode/-/punycode-2.3.0.tgz#f67fa67c94da8f4d0cfff981aee4118064199b8f"
910+
integrity sha512-rRV+zQD8tVFys26lAGR9WUuS4iUAngJScM+ZRSKtvl5tKeZ2t5bvdNFdNHBW9FWR4guGHlgmsZ1G7BSm2wTbuA==
911911

912912
queue-microtask@^1.2.2:
913913
version "1.2.3"

0 commit comments

Comments
 (0)