Skip to content

Commit 545d381

Browse files
committed
Fix NPE
1 parent b3a48d4 commit 545d381

File tree

2 files changed

+5
-6
lines changed

2 files changed

+5
-6
lines changed

heron/common/src/java/org/apache/heron/common/network/HeronClient.java

+5-5
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,9 @@
2424
import java.nio.channels.SelectableChannel;
2525
import java.nio.channels.SocketChannel;
2626
import java.time.Duration;
27-
import java.util.HashMap;
2827
import java.util.List;
2928
import java.util.Map;
29+
import java.util.Objects;
3030
import java.util.concurrent.ConcurrentHashMap;
3131
import java.util.logging.Level;
3232
import java.util.logging.Logger;
@@ -194,7 +194,7 @@ public void sendRequest(Message request, Object context, Message.Builder respons
194194
Duration timeout) {
195195
// Pack it as a no-timeout request and send it!
196196
final REQID rid = REQID.generate();
197-
contextMap.put(rid, context);
197+
contextMap.put(rid, Objects.nonNull(context) ? context: new Object());
198198
responseMessageMap.put(rid, responseBuilder);
199199

200200
// Add timeout for this request if necessary
@@ -403,15 +403,15 @@ public void forceFlushWithBestEffort() {
403403
// Following protected methods are just used for testing
404404
/////////////////////////////////////////////////////////
405405
protected Map<String, Message.Builder> getMessageMap() {
406-
return new HashMap<String, Message.Builder>(messageMap);
406+
return new ConcurrentHashMap<String, Message.Builder>(messageMap);
407407
}
408408

409409
protected Map<REQID, Message.Builder> getResponseMessageMap() {
410-
return new HashMap<REQID, Message.Builder>(responseMessageMap);
410+
return new ConcurrentHashMap<REQID, Message.Builder>(responseMessageMap);
411411
}
412412

413413
protected Map<REQID, Object> getContextMap() {
414-
return new HashMap<REQID, Object>(contextMap);
414+
return new ConcurrentHashMap<>(contextMap);
415415
}
416416

417417
protected SocketChannelHelper getSocketChannelHelper() {

heron/common/src/java/org/apache/heron/common/utils/metrics/MetricsCollector.java

-1
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@
2222

2323
import java.time.Duration;
2424
import java.util.Collection;
25-
import java.util.HashMap;
2625
import java.util.LinkedList;
2726
import java.util.List;
2827
import java.util.Map;

0 commit comments

Comments
 (0)