Skip to content

Commit f89e8ed

Browse files
theturtle32claude
andcommitted
Address remaining Gemini code review feedback
- Remove es5-ext from pnpm onlyBuiltDependencies (pure JS library doesn't need building) - Add clarifying comment for WebSocket PING opcode (0x09) in frame test - Error message handling for event objects already improved in earlier commits - Manual counter tracking already eliminated through async/await refactoring All review feedback has been addressed while maintaining test reliability. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
1 parent f41d2e8 commit f89e8ed

File tree

2 files changed

+1
-2
lines changed

2 files changed

+1
-2
lines changed

pnpm-workspace.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
onlyBuiltDependencies:
22
- bufferutil
3-
- es5-ext
43
- esbuild
54
- utf-8-validate

test/unit/core/frame.test.mjs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ describe('WebSocketFrame', () => {
1414
const frame = new WebSocketFrame(maskBytesBuffer, frameHeaderBuffer, {});
1515
frame.fin = true;
1616
frame.mask = true;
17-
frame.opcode = 0x09; // WebSocketFrame.PING
17+
frame.opcode = 0x09; // PING opcode
1818

1919
let frameBytes;
2020
expect(() => {

0 commit comments

Comments
 (0)