Skip to content

Unit and integration tests are lacking #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thesketh opened this issue Mar 2, 2020 · 3 comments
Open

Unit and integration tests are lacking #3

thesketh opened this issue Mar 2, 2020 · 3 comments
Labels
testing Changes to unit or integration tests

Comments

@thesketh
Copy link
Owner

thesketh commented Mar 2, 2020

At present, the unit tests mostly cover the charmm_containers module. This is intentional - these classes have been the source of most of the issues I've discovered in the past - but issues with Molecule and Structure would also have far-reaching implications. The unit tests should be expanded upon.

Additionally, more integration tests are required. The OpenMM test is useful, as it tests both structure generation and PSF/PDB format structure. More tests using OpenMM or other simulation packages, perhaps for some more difficult molecules, would be ideal.

@thesketh
Copy link
Owner Author

Additional tests added in 3c9c8e2, so now over 80% coverage.

Tests to cover command line usage are still necessary.

@RMeli
Copy link

RMeli commented Mar 15, 2020

Any short-term plans to bump code coverage even higher?

@thesketh
Copy link
Owner Author

I've added tests for the command-line portion of the software, so coverage is ~91% now

@thesketh thesketh removed this from the v0.2.3 milestone Mar 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Changes to unit or integration tests
Projects
None yet
Development

No branches or pull requests

2 participants