-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(build): Move needed devDependencies to dependencies #89
Conversation
@theoomoregbee There still seem to be something odd going on - Travis CI has been triggered but not noted here? See https://travis-ci.org/github/theoomoregbee/sails-hook-swagger-generator/builds/725459962 Also |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will take a look with what is wrong with the commit bot.
Left a minor comment
https://github.com/z0al/commitlint-bot is deprecated and not maintained again, updated to use https://github.com/apps/semantic-pull-requests |
FYI: I closed and open to see if it will trigger the new bot. I guess it's for new PRs |
@theoomoregbee Just a note that the TravisCI link above show the build OK, but it is not listed as a check for the PR: |
🎉 This PR is included in version 3.2.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Several modules were included as devDependencies but should be dependencies; closes #88