feat: Add option to excluded deprecated PUT update blueprint (default)
#73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielsharvey
force-pushed
the
excl-deprecated
branch
2 times, most recently
from
3264686 to
a6b3da8
Compare
Sails 1.0 includes `PUT` and `PATCH` routes to the `update` blueprint although `PUT` deprecated; default to excluding the `PUT` route. See - https://sailsjs.com/documentation/reference/blueprint-api/update#?notes - https://github.com/balderdashy/sails/blob/master/lib/hooks/blueprints/index.js#L401
danielsharvey
force-pushed
the
excl-deprecated
branch
from
a6b3da8 to
f186232
Compare
README.MD
Outdated
| @@ -85,6 +85,9 @@ module.exports['swagger-generator'] = { | |||
| '500': { description: 'Internal server error' } | |||
| } | |||
| }, | |||
| options: { | |||
| excludeDeprecatedPutBlueprintRoutes: true, | |||
There was a problem hiding this comment.
just curious, any reason adding this to options what about just adding it directly to
There was a problem hiding this comment.
I feel it's a better ux to just add more options to SwaggerGenerator
There was a problem hiding this comment.
Apologies, I added it this way and meant to ask you but forgot. I will change it as per your comment.
theoomoregbee
approved these changes
Jun 6, 2020
There was a problem hiding this comment.
LGTM, just a minor comment: https://github.com/theoomoregbee/sails-hook-swagger-generator/pull/73/files#r436273501
|
🎉 This PR is included in version 3.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sails 1.0 includes
PUTandPATCHroutes to theupdateblueprint althoughPUTdeprecated; default to excluding thePUTroute.See