fix: Update blueprint request body schema should not specified 'required' #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
danielsharvey
force-pushed
the
fix-update-schema
branch
2 times, most recently
from
54b550b to
4ced158
Compare
theoomoregbee
dismissed
their stale review
wait for #67 to be merged before merging this
danielsharvey
force-pushed
the
fix-update-schema
branch
from
4ced158 to
d2d5c00
Compare
|
@danielsharvey this should be good to go in too after resolving conflicts |
Sails Models include specification of `required` property for
attributes. This should be enforced/specified for create blueprints
but **NOT** update blueprints.
This change adds two variant schemas for each model:
- '{modelIdentity}' - variant containing `required`
- '{modelIdentity}-without-required-constraint' - used for updates
Correct `generateSchemas()` test data
danielsharvey
force-pushed
the
fix-update-schema
branch
from
d2d5c00 to
1acd5c8
Compare
|
🎉 This PR is included in version 3.1.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sails Models include specification of
requiredproperty for attributes. This should be enforced/specified for create blueprints but NOT update blueprints.This change adds two variant schemas for each model:
{modelIdentity}- variant containingrequired{modelIdentity}-without-required-constraint- used for updates