Skip to content

Commit 023ae4c

Browse files
committed
client uses generated protocol type
1 parent 292be9c commit 023ae4c

File tree

2 files changed

+19
-27
lines changed

2 files changed

+19
-27
lines changed

src/client/client.ts

+12-13
Original file line numberDiff line numberDiff line change
@@ -494,7 +494,7 @@ function renderAndMaybeCommitSelection(selection: {[index: ObjectId]: ObjectTemp
494494
clearNumberBuffer();
495495
}
496496
function commitSelection(selection: {[index: ObjectId]: ObjectTempProps}) {
497-
let move: any[] = []; // TODO
497+
let move: (string | number)[] = [];
498498
move.push(getMyUserId());
499499
for (let id in selection) {
500500
let object = objectsById[id];
@@ -532,14 +532,13 @@ function commitSelection(selection: {[index: ObjectId]: ObjectTempProps}) {
532532
}
533533
}
534534
if (move.length <= 1) return;
535-
let message = {
535+
sendMessage({
536536
cmd: "makeAMove",
537537
args: move,
538-
};
539-
sendMessage(message);
538+
});
540539
pushChangeToHistory(move);
541540
}
542-
function pushObjectProps(move: any[], object: ObjectState) { // TODO
541+
function pushObjectProps(move: (string | number)[], object: ObjectState) {
543542
move.push(
544543
object.id,
545544
object.prototype,
@@ -549,14 +548,14 @@ function pushObjectProps(move: any[], object: ObjectState) { // TODO
549548
object.faceIndex);
550549
}
551550
const objectPropCount = 6;
552-
function consumeObjectProps(move: any[], i: number): ObjectState { // TODO
551+
function consumeObjectProps(move: (string | number)[], i: number): ObjectState {
553552
let object = makeObject(
554-
move[i++], // id
555-
move[i++], // prototypeId
556-
move[i++], // x
557-
move[i++], // y
558-
move[i++], // z
559-
move[i++], // faceIndex
553+
move[i++] as string, // id
554+
move[i++] as string, // prototypeId
555+
move[i++] as number, // x
556+
move[i++] as number, // y
557+
move[i++] as number, // z
558+
move[i++] as number, // faceIndex
560559
);
561560
return object;
562561
}
@@ -707,7 +706,7 @@ function deleteSelection() {
707706
partialDeletion = true;
708707
}
709708

710-
let move: any[] = []; // TODO
709+
let move: (string | number)[] = [];
711710
objects.forEach(function(object) {
712711
if (!object.temporary) {
713712
move.push("d"); // delete

src/client/connection.ts

+7-14
Original file line numberDiff line numberDiff line change
@@ -1,24 +1,17 @@
1-
import {programmerError} from "./math.js";
2-
import {
3-
initGame, deleteTableAndEverything,
4-
makeAMove,
5-
} from "./client.js";
6-
import {
7-
UserInfo, UserId,
8-
JoinRoomArgs, UserJoinedArgs, UserLeftArgs, ChangeMyNameArgs, ChangeMyRoleArgs, RoleId,
9-
} from "../shared/protocol.js";
10-
import {
11-
ScreenMode, getScreenMode, setScreenMode,
12-
renderUserList,
13-
} from "./ui_layout.js";
1+
import { programmerError } from "./math.js";
2+
import { initGame, deleteTableAndEverything, makeAMove } from "./client.js";
3+
import { ScreenMode, getScreenMode, setScreenMode, renderUserList } from "./ui_layout.js";
4+
5+
import { UserInfo, UserId, JoinRoomArgs, UserJoinedArgs, UserLeftArgs, ChangeMyNameArgs, ChangeMyRoleArgs, RoleId } from "../shared/protocol.js";
6+
import { ProtocolMessage } from "../shared/generated-schema.js";
147

158
let socket: WebSocket | null = null;
169
let isConnected = false;
1710
let roomCode: string | null = null;
1811
let myUser: UserInfo | null = null;
1912
let usersById: {[index: UserId]: UserInfo} = {};
2013

21-
export function sendMessage(message: object) {
14+
export function sendMessage(message: ProtocolMessage) {
2215
if (socket == null) programmerError();
2316
socket.send(JSON.stringify(message));
2417
}

0 commit comments

Comments
 (0)