Skip to content

Commit 431fed2

Browse files
[dvs/NAT] Fix for test_VerifyConntrackTimeoutForNatEntry test case (sonic-net#1417)
Signed-off-by: Akhilesh Samineni <[email protected]>
1 parent 013fc24 commit 431fed2

File tree

1 file changed

+3
-5
lines changed

1 file changed

+3
-5
lines changed

tests/test_nat.py

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
import time
2-
import pytest
32

43
from dvslib.dvs_common import wait_for_result
54
from dvslib.dvs_database import DVSDatabase
@@ -283,7 +282,6 @@ def test_DelTwiceNaPtStaticEntry(self, dvs, testlog):
283282
# clear interfaces
284283
self.clear_interfaces(dvs)
285284

286-
@pytest.mark.skip("Issue #1409")
287285
def test_VerifyConntrackTimeoutForNatEntry(self, dvs, testlog):
288286
# get neighbor and arp entry
289287
dvs.servers[0].runcmd("ping -c 1 18.18.18.2")
@@ -308,11 +306,11 @@ def _check_conntrack_for_static_entry():
308306

309307
proto_index = conntrack_list.index("udp")
310308

311-
# FIXME: conntrack_list[proto_index + 7] is consistently returning 431995. Need the feature owner
312-
# to confirm if this check is wrong or if the behavior is wrong.
313-
if int(conntrack_list[proto_index + 7]) < 432000 and int(conntrack_list[proto_index + 7]) > 431900:
309+
if int(conntrack_list[proto_index + 7]) > 432000 or int(conntrack_list[proto_index + 7]) < 431900:
314310
return (False, None)
315311

312+
return (True, None)
313+
316314
wait_for_result(_check_conntrack_for_static_entry, DVSDatabase.DEFAULT_POLLING_CONFIG)
317315

318316
# delete a static nat entry

0 commit comments

Comments
 (0)