Skip to content

Experiment with single Append Prometheus method is blocking us or not. #3812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bwplotka opened this issue Feb 18, 2021 · 3 comments · Fixed by #3936
Closed

Experiment with single Append Prometheus method is blocking us or not. #3812

bwplotka opened this issue Feb 18, 2021 · 3 comments · Fixed by #3936
Assignees
@metalmatze
Labels
help wanted

Comments

@bwplotka
Copy link
Member

Ref: prometheus/prometheus#8489 (comment)
@metalmatze
Copy link
Contributor

Did we already start working on this? Happy to help with it!

@bwplotka
Copy link
Member Author

Nope 🤗
I think essentially we need to upgrade to latest Prometheus and check if we can, with the totally new Appender API!

@bwplotka
Copy link
Member Author

Nope 🤗

I mean, nope that someone started working on it, feel free to help 🤗

@metalmatze metalmatze mentioned this issue Mar 16, 2021
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@metalmatze metalmatze

Labels
help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use new storage.Appender Append() instead of Add & AddFast metalmatze/thanos
2 participants
@metalmatze @bwplotka