Skip to content

Commit d9368aa

Browse files
committed
refactor: changed logging of highest error using logger
1 parent 27fedb8 commit d9368aa

File tree

2 files changed

+4
-5
lines changed

2 files changed

+4
-5
lines changed

cmd/thanos/check.go

+3-4
Original file line numberDiff line numberDiff line change
@@ -55,16 +55,15 @@ func checkRulesFiles(logger log.Logger, files *[]string) error {
5555
return nil
5656
}
5757

58-
type ThanosRuleGroup struct{
59-
PartialResponseStrategy string `yaml:"partial_response_strategy"`
60-
rulefmt.RuleGroup `yaml:",inline"`
58+
type ThanosRuleGroup struct {
59+
PartialResponseStrategy string `yaml:"partial_response_strategy"`
60+
rulefmt.RuleGroup `yaml:",inline"`
6161
}
6262

6363
type ThanosRuleGroups struct {
6464
Groups []ThanosRuleGroup `yaml:"groups"`
6565
}
6666

67-
6867
func checkRules(logger log.Logger, filename string) (int, tsdb.MultiError) {
6968
level.Info(logger).Log("msg", "checking", "filename", filename)
7069
checkErrors := tsdb.MultiError{}

cmd/thanos/main.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -165,7 +165,7 @@ func main() {
165165
}
166166

167167
if err := cmds[cmd](&g, logger, metrics, tracer, *logLevel == "debug"); err != nil {
168-
fmt.Fprintln(os.Stderr, errors.Wrapf(err, "%s command failed", cmd))
168+
level.Error(logger).Log("err", errors.Wrapf(err, "%s command failed", cmd))
169169
os.Exit(1)
170170
}
171171

0 commit comments

Comments
 (0)