feat: add esm support #55
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoviDeCroock
commented
May 19, 2022
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "presets": [ | |||
| ["@babel/preset-env", { "targets": { "node": "8" } }]], | |||
| ["@babel/preset-env", { "targets": { "node": "12" } }]], | |||
There was a problem hiding this comment.
This is our supported version according to pkg.json
|
🎉 This PR is included in version 3.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
rschristian
reviewed
May 24, 2022
Comment on lines
+10
to
+17
| "types": "./types/index.d.ts", | ||
| "import": "./dist/esm/index.js", | ||
| "browser": "./dist/cjs/index.js" | ||
| }, | ||
| "./pure": { | ||
| "types": "./pure.d.ts", | ||
| "import": "./dist/esm/pure.js", | ||
| "browser": "./dist/cjs/pure.js" |
There was a problem hiding this comment.
ESM output as .js with no "type": "module"? Any reason not to support Node here?
"browser" being CJS also looks a bit odd to me, though could be fine.
There was a problem hiding this comment.
Yes I realised a moment ago as well, we have to output these as mjs as well
There was a problem hiding this comment.
Ah, apologies then!
Thanks for doing all of this!
There was a problem hiding this comment.
No need to apologize, was a very good shout, thanks 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #50
Resolves #36
What:
This adds support for importing this library as ESM. Therefore we are also introducing the concept of export maps as this will allow people to use esm for all things testing library.
Why:
We are increasingly growing towards ESM as a baseline so we should support both modes.
How:
We initiate two Babel runs, one resulting in ESM and one resulting in CJS.
Checklist: