Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Valkey Testcontainer with Custom Configuration and Latest Image Support #314

Open
ungerts opened this issue Mar 15, 2025 · 0 comments · May be fixed by #315
Open

Enhance Valkey Testcontainer with Custom Configuration and Latest Image Support #314

ungerts opened this issue Mar 15, 2025 · 0 comments · May be fixed by #315
Labels
enhancement New feature or request

Comments

@ungerts
Copy link

ungerts commented Mar 15, 2025

Feature request description

Feature Request: Enhance Valkey Testcontainer with Custom Configuration and Latest Image Support

Description

Enhance the testcontainers-rust Valkey module to support additional configuration methods and improve flexibility in test environments.

Proposed Features

  1. Support for Custom Valkey Configuration Using Extra Flags

    • Allow users to pass additional command-line flags to the Valkey container.
    • Example:
      Valkey::default().with_valkey_extra_flags("--maxmemory 2mb")
  2. Support for Custom Valkey Configuration Using a Custom valkey.conf

    • Enable users to mount a custom valkey.conf file into the container.
    • This allows for more complex and persistent configurations.
    • Example:
      Valkey::default().with_valkey_conf("maxmemory 2mb".to_string().into_bytes(),)
  3. Support for the Latest Image Tag

    • Provide an option to use the latest available Valkey Docker image (valkey/valkey:latest).
    • Ensure compatibility with the latest Valkey features without requiring manual tag updates.
    • Example:
      Valkey::latest()

Motivation

These improvements allow for greater flexibility when using Valkey in integration tests, enabling developers to:

  • Leverage advanced Valkey features.
  • Ensure compatibility with specific configurations.
  • Test against the latest Valkey versions easily.

Image reference

Official Valkey Docker Image: https://hub.docker.com/r/valkey/valkey/

@ungerts ungerts added the enhancement New feature or request label Mar 15, 2025
ungerts added a commit to ungerts/testcontainers-rs-modules-community that referenced this issue Mar 15, 2025
ungerts added a commit to ungerts/testcontainers-rs-modules-community that referenced this issue Mar 15, 2025
Add support for passing extra flags to Valkey container. Enable mounting a custom `valkey.conf` file for advanced configurations. Allow using `valkey/valkey:latest` image tag for testing against the latest version. Improves flexibility in integration tests by enabling more Valkey features.

Closes testcontainers#314
ungerts added a commit to ungerts/testcontainers-rs-modules-community that referenced this issue Mar 15, 2025
Add support for passing extra flags to Valkey container. Enable mounting a custom `valkey.conf` file for advanced configurations. Allow using `valkey/valkey:latest` image tag for testing against the latest version. Improves flexibility in integration tests by enabling more Valkey features.

Closes testcontainers#314
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
1 participant