Remove dependency upon internet URLs for selenium tests (#3271)

Author: rnorth

modules/selenium/src/test/java/org/testcontainers/junit/BaseWebDriverContainerTest.java

@@ -1,62 +1,62 @@
 package org.testcontainers.junit;
 
 import org.jetbrains.annotations.NotNull;
+import org.junit.ClassRule;
 import org.openqa.selenium.By;
 import org.openqa.selenium.WebElement;
 import org.openqa.selenium.remote.RemoteWebDriver;
-import org.openqa.selenium.support.ui.ExpectedConditions;
-import org.openqa.selenium.support.ui.WebDriverWait;
 import org.testcontainers.containers.BrowserWebDriverContainer;
+import org.testcontainers.containers.GenericContainer;
+import org.testcontainers.containers.Network;
+import org.testcontainers.containers.wait.strategy.HttpWaitStrategy;
+import org.testcontainers.utility.DockerImageName;
 
-import java.util.List;
 import java.util.concurrent.TimeUnit;
 
 import static java.lang.String.format;
+import static org.rnorth.visibleassertions.VisibleAssertions.assertEquals;
 import static org.rnorth.visibleassertions.VisibleAssertions.assertTrue;
 
 /**
  *
  */
 public class BaseWebDriverContainerTest {
 
-    protected void doSimpleWebdriverTest(BrowserWebDriverContainer rule) {
+    @ClassRule
+    public static Network NETWORK = Network.newNetwork();
+
+    @ClassRule
+    public static GenericContainer<?> HELLO_WORLD = new GenericContainer<>(DockerImageName.parse("testcontainers/helloworld:1.0.0"))
+        .withNetwork(NETWORK)
+        .withNetworkAliases("helloworld")
+        .withExposedPorts(8080, 8081)
+        .waitingFor(new HttpWaitStrategy());
+
+    protected static void doSimpleExplore(BrowserWebDriverContainer<?> rule) {
         RemoteWebDriver driver = setupDriverFromRule(rule);
         System.out.println("Selenium remote URL is: " + rule.getSeleniumAddress());
         System.out.println("VNC URL is: " + rule.getVncAddress());
 
-        driver.get("http://www.google.com");
-        WebElement search = driver.findElement(By.name("q"));
-        search.sendKeys("testcontainers");
-        search.submit();
+        driver.get("http://helloworld:8080");
+        WebElement title = driver.findElement(By.tagName("h1"));
 
-        List<WebElement> results = new WebDriverWait(driver, 15)
-            .until(ExpectedConditions.visibilityOfAllElementsLocatedBy(By.cssSelector("#search h3")));
-
-        assertTrue("the word 'testcontainers' appears in search results",
-            results.stream()
-                .anyMatch(el -> el.getText().contains("testcontainers")));
+        assertEquals("the index page contains the title 'Hello world'",
+            "Hello world",
+            title.getText().trim()
+        );
     }
 
-    protected void assertBrowserNameIs(BrowserWebDriverContainer rule, String expectedName) {
+    protected void assertBrowserNameIs(BrowserWebDriverContainer<?> rule, String expectedName) {
         RemoteWebDriver driver = setupDriverFromRule(rule);
         String actual = driver.getCapabilities().getBrowserName();
         assertTrue(format("actual browser name is %s", actual),
             actual.equals(expectedName));
     }
 
     @NotNull
-    private static RemoteWebDriver setupDriverFromRule(BrowserWebDriverContainer rule) {
+    private static RemoteWebDriver setupDriverFromRule(BrowserWebDriverContainer<?> rule) {
         RemoteWebDriver driver = rule.getWebDriver();
         driver.manage().timeouts().implicitlyWait(30, TimeUnit.SECONDS);
         return driver;
     }
-
-    protected static void doSimpleExplore(BrowserWebDriverContainer rule) {
-        RemoteWebDriver driver = setupDriverFromRule(rule);
-        driver.get("http://en.wikipedia.org/wiki/Randomness");
-
-        // Oh! The irony!
-        assertTrue("Randomness' description has the word 'pattern'", driver.findElementByPartialLinkText("pattern").isDisplayed());
-    }
-
 }

modules/selenium/src/test/java/org/testcontainers/junit/ChromeRecordingWebDriverContainerTest.java

@@ -33,11 +33,12 @@ public void recordingTestThatShouldBeRecordedAndRetained() {
             try (
                 // recordAll {
                 // To do this, simply add extra parameters to the rule constructor:
-                BrowserWebDriverContainer chrome = new BrowserWebDriverContainer()
+                BrowserWebDriverContainer<?> chrome = new BrowserWebDriverContainer<>()
                     .withCapabilities(new ChromeOptions())
                     .withRecordingMode(RECORD_ALL, target)
                     // }
                     .withRecordingFileFactory(new DefaultRecordingFileFactory())
+                    .withNetwork(NETWORK)
             ) {
                 chrome.start();
 
@@ -69,12 +70,13 @@ public static class ChromeThatRecordsFailingTests {
         public void recordingTestThatShouldBeRecordedButNotPersisted() {
             try (
                 // withRecordingFileFactory {
-                BrowserWebDriverContainer chrome = new BrowserWebDriverContainer()
+                BrowserWebDriverContainer<?> chrome = new BrowserWebDriverContainer<>()
                     // }
                     .withCapabilities(new ChromeOptions())
                     // withRecordingFileFactory {
                     .withRecordingFileFactory(new CustomRecordingFileFactory())
-                // }
+                    // }
+                    .withNetwork(NETWORK)
             ) {
                 chrome.start();
 
@@ -88,11 +90,12 @@ public void recordingTestThatShouldBeRecordedAndRetained() {
             try (
                 // recordFailing {
                 // or if you only want videos for test failures:
-                BrowserWebDriverContainer chrome = new BrowserWebDriverContainer()
+                BrowserWebDriverContainer<?> chrome = new BrowserWebDriverContainer<>()
                     .withCapabilities(new ChromeOptions())
                     .withRecordingMode(RECORD_FAILING, target)
                     // }
                     .withRecordingFileFactory(new DefaultRecordingFileFactory())
+                    .withNetwork(NETWORK)
             ) {
                 chrome.start();
 
@@ -115,6 +118,7 @@ public String getFilesystemFriendlyName() {
 
         }
 
-        private static class CustomRecordingFileFactory extends DefaultRecordingFileFactory { }
+        private static class CustomRecordingFileFactory extends DefaultRecordingFileFactory {
+        }
     }
 }

modules/selenium/src/test/java/org/testcontainers/junit/ChromeWebDriverContainerTest.java

@@ -13,20 +13,16 @@ public class ChromeWebDriverContainerTest extends BaseWebDriverContainerTest {
 
     // junitRule {
     @Rule
-    public BrowserWebDriverContainer chrome = new BrowserWebDriverContainer()
-        .withCapabilities(new ChromeOptions());
+    public BrowserWebDriverContainer<?> chrome = new BrowserWebDriverContainer<>()
+        .withCapabilities(new ChromeOptions())
     // }
+        .withNetwork(NETWORK);
 
     @Before
     public void checkBrowserIsIndeedChrome() {
         assertBrowserNameIs(chrome, "chrome");
     }
 
-    @Test
-    public void simpleTest() {
-        doSimpleWebdriverTest(chrome);
-    }
-
     @Test
     public void simpleExploreTest() {
         doSimpleExplore(chrome);

modules/selenium/src/test/java/org/testcontainers/junit/ContainerWithoutCapabilitiesTest.java

@@ -7,7 +7,8 @@
 public class ContainerWithoutCapabilitiesTest extends BaseWebDriverContainerTest{
 
     @Rule
-    public BrowserWebDriverContainer chrome = new BrowserWebDriverContainer();
+    public BrowserWebDriverContainer<?> chrome = new BrowserWebDriverContainer<>()
+        .withNetwork(NETWORK);
 
     @Test
     public void chromeIsStartedIfNoCapabilitiesProvided() {

modules/selenium/src/test/java/org/testcontainers/junit/CustomWaitTimeoutWebDriverContainerTest.java

@@ -15,12 +15,13 @@
 public class CustomWaitTimeoutWebDriverContainerTest extends BaseWebDriverContainerTest {
 
     @Rule
-    public BrowserWebDriverContainer chromeWithCustomTimeout = new BrowserWebDriverContainer<>()
-            .withCapabilities(new ChromeOptions())
-            .withStartupTimeout(Duration.of(30, SECONDS));
+    public BrowserWebDriverContainer<?> chromeWithCustomTimeout = new BrowserWebDriverContainer<>()
+        .withCapabilities(new ChromeOptions())
+        .withStartupTimeout(Duration.of(30, SECONDS))
+        .withNetwork(NETWORK);
 
     @Test
-    public void simpleTest() {
-        doSimpleWebdriverTest(chromeWithCustomTimeout);
+    public void simpleExploreTest() {
+        doSimpleExplore(chromeWithCustomTimeout);
     }
 }

modules/selenium/src/test/java/org/testcontainers/junit/FirefoxWebDriverContainerTest.java

@@ -13,20 +13,16 @@ public class FirefoxWebDriverContainerTest extends BaseWebDriverContainerTest {
 
     // junitRule {
     @Rule
-    public BrowserWebDriverContainer firefox = new BrowserWebDriverContainer()
-            .withCapabilities(new FirefoxOptions());
+    public BrowserWebDriverContainer<?> firefox = new BrowserWebDriverContainer<>()
+            .withCapabilities(new FirefoxOptions())
     // }
+        .withNetwork(NETWORK);
 
     @Before
     public void checkBrowserIsIndeedFirefox() {
         assertBrowserNameIs(firefox, "firefox");
     }
 
-    @Test
-    public void simpleTest() {
-        doSimpleWebdriverTest(firefox);
-    }
-
     @Test
     public void simpleExploreTest() {
         doSimpleExplore(firefox);

modules/selenium/src/test/java/org/testcontainers/junit/FlakyContainerCreationTest.java

@@ -12,12 +12,8 @@ public class SpecificImageNameWebDriverContainerTest extends BaseWebDriverContai
 
     @Rule
     public BrowserWebDriverContainer<?> firefox = new BrowserWebDriverContainer<>(FIREFOX_IMAGE)
-        .withCapabilities(new FirefoxOptions());
-
-    @Test
-    public void simpleTest() {
-        doSimpleWebdriverTest(firefox);
-    }
+        .withCapabilities(new FirefoxOptions())
+        .withNetwork(NETWORK);
 
     @Test
     public void simpleExploreTest() {