Skip to content

Commit 0842999

Browse files
committed
Convert Docs for Webdriver Containers
Convert inline example code to use codeinclude macro for the Webdriver Containers documentation. See #1158 for more details. Fixed ChromeRecordingWebDriverContainerTest which was crashed by previous commit. Fix Labels for RECORD_ALL, RECORD_FAILING enum values.
1 parent 62a6be8 commit 0842999

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

docs/modules/webdriver_containers.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -59,8 +59,8 @@ By default, no videos will be recorded. However, you can instruct Testcontainers
5959
just for failing tests.
6060

6161
<!--codeinclude-->
62-
[RECORD_ALL](../../modules/selenium/src/test/java/org/testcontainers/junit/ChromeRecordingWebDriverContainerTest.java) inside_block:recordAll
63-
[RECORD_FAILING](../../modules/selenium/src/test/java/org/testcontainers/junit/ChromeRecordingWebDriverContainerTest.java) inside_block:recordFailing
62+
[Record all Tests](../../modules/selenium/src/test/java/org/testcontainers/junit/ChromeRecordingWebDriverContainerTest.java) inside_block:recordAll
63+
[Record failing Tests](../../modules/selenium/src/test/java/org/testcontainers/junit/ChromeRecordingWebDriverContainerTest.java) inside_block:recordFailing
6464
<!--/codeinclude-->
6565

6666
Note that the seconds parameter to `withRecordingMode` should be a directory where recordings can be saved.

modules/selenium/src/test/java/org/testcontainers/junit/ChromeRecordingWebDriverContainerTest.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -76,6 +76,8 @@ public void recordingTestThatShouldBeRecordedButNotPersisted() {
7676
.withRecordingFileFactory(new CustomRecordingFileFactory())
7777
// }
7878
) {
79+
chrome.start();
80+
7981
doSimpleExplore(chrome);
8082
}
8183
}

0 commit comments

Comments
 (0)