Skip to content

Commit fbeb55c

Browse files
committed
Fix CID 1164526 (Resource leak in object)
stream_ was allocated in the constructor, but the destructor did not free it. Signed-off-by: Stefan Weil <[email protected]>
1 parent b87fc52 commit fbeb55c

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

src/viewer/svutil.cpp

+3
Original file line numberDiff line numberDiff line change
@@ -279,6 +279,8 @@ void SVNetwork::Close() {
279279
#else
280280
close(stream_);
281281
#endif
282+
// Mark stream_ as invalid.
283+
stream_ = -1;
282284
}
283285

284286

@@ -448,6 +450,7 @@ SVNetwork::SVNetwork(const char* hostname, int port) {
448450
}
449451

450452
SVNetwork::~SVNetwork() {
453+
Close();
451454
delete[] msg_buffer_in_;
452455
}
453456

0 commit comments

Comments
 (0)