opencl: Fix wrong implementation of function getNumDeviceWithEmptyScore

stweil · stweil · commit 90dad1f2ae97 · 2016-11-05T20:57:30.000+01:00
gcc report:

opencl_device_selection.h: In function 'ds_status getNumDeviceWithEmptyScore(ds_profile*, unsigned int*)':
opencl_device_selection.h:589:13: warning: value computed is not used [-Wunused-value]
       *num++;
             ^

This is caused by a buggy implementation which increases the value of num
instead of *num.

Signed-off-by: Stefan Weil &lt;sw@weilnetz.de&gt;
diff --git a/opencl/opencl_device_selection.h b/opencl/opencl_device_selection.h
@@ -586,7 +586,7 @@ static ds_status getNumDeviceWithEmptyScore(ds_profile* profile,
   *num=0;
   for (i = 0; i < profile->numDevices; i++) {
     if (profile->devices[i].score == NULL) {
-      *num++;
+      (*num)++;
     }
   }
   return DS_SUCCESS;

Original file line number	Diff line number	Diff line change
`@@ -586,7 +586,7 @@ static ds_status getNumDeviceWithEmptyScore(ds_profile* profile,`
`586`	`586`	`*num=0;`
`587`	`587`	`for (i = 0; i < profile->numDevices; i++) {`
`588`	`588`	`if (profile->devices[i].score == NULL) {`
`589`		`- *num++;`
	`589`	`+ (*num)++;`
`590`	`590`	`}`
`591`	`591`	`}`
`592`	`592`	`return DS_SUCCESS;`