Simplify new operations

It is not necessary to check for null pointers after new.

Signed-off-by: Stefan Weil <[email protected]>

Author: stweil

api/pdfrenderer.cpp

@@ -819,10 +819,6 @@ bool TessPDFRenderer::imageToPDFObj(Pix *pix,
   *pdf_object_size =
       b1_len + colorspace_len + b2_len + cid->nbytescomp + b3_len;
   *pdf_object = new char[*pdf_object_size];
-  if (!pdf_object) {
-    l_CIDataDestroy(&cid);
-    return false;
-  }
 
   char *p = *pdf_object;
   memcpy(p, b1, b1_len);

dict/trie.cpp

@@ -276,7 +276,6 @@ bool Trie::add_word_to_dawg(const WERD_CHOICE &word,
 
 NODE_REF Trie::new_dawg_node() {
   TRIE_NODE_RECORD *node = new TRIE_NODE_RECORD();
-  if (node == NULL) return 0;  // failed to create new node
   nodes_.push_back(node);
   return nodes_.length() - 1;
 }

neural_networks/runtime/neural_net.cpp

@@ -157,9 +157,6 @@ bool NeuralNet::CreateFastNet() {
       node->fan_in_cnt = neurons_[node_idx].fan_in_cnt();
       // allocate memory for fan-in nodes
       node->inputs = new WeightedNode[node->fan_in_cnt];
-      if (node->inputs == NULL) {
-        return false;
-      }
       for (int fan_in = 0; fan_in < node->fan_in_cnt; fan_in++) {
         // identify fan-in neuron
         const int id = neurons_[node_idx].fan_in(fan_in)->id();
@@ -222,9 +219,6 @@ NeuralNet *NeuralNet::FromFile(const string file_name) {
 NeuralNet *NeuralNet::FromInputBuffer(InputFileBuffer *ib) {
       // create a new net object
   NeuralNet *net_obj = new NeuralNet();
-  if (net_obj == NULL) {
-    return NULL;
-  }
       // load the net
   if (!net_obj->ReadBinary(ib)) {
     delete net_obj;

neural_networks/runtime/neural_net.h

@@ -140,9 +140,6 @@ class NeuralNet {
       }
       // set the size of the neurons vector
       neurons_ = new Neuron[neuron_cnt_];
-      if (neurons_ == NULL) {
-        return false;
-      }
       // read & validate inputs
       if (input_buff->Read(&read_val, sizeof(read_val)) != sizeof(read_val)) {
         return false;

textord/topitch.cpp

@@ -1285,8 +1285,6 @@ float tune_row_pitch2(                             //find fp cells
     return initial_pitch;
   }
   sum_proj = new STATS[textord_pitch_range * 2 + 1];
-  if (sum_proj == NULL)
-    return initial_pitch;
 
   for (pitch_delta = -textord_pitch_range; pitch_delta <= textord_pitch_range;
     pitch_delta++)