Fixed CID 1164537 (possible division by zero)

noahmetzger · noahmetzger · commit 2193f81702f1 · 2018-05-03T14:55:41.000+02:00
If height_count stays zero the maximal error calculation contains a division by zero.

Signed-off-by: Noah Metzger &lt;noah.metzger@bib.uni-mannheim.de&gt;
diff --git a/src/textord/colpartition.cpp b/src/textord/colpartition.cpp
@@ -1343,6 +1343,8 @@ bool ColPartition::HasGoodBaseline() {
     width = last_pt.x() - first_pt.x();
   }
   // Maximum median error allowed to be a good text line.
+  if (height_count == 0) 
+    return false;
   double max_error = kMaxBaselineError * total_height / height_count;
   ICOORD start_pt, end_pt;
   double error = linepoints.Fit(&start_pt, &end_pt);

Original file line number	Diff line number	Diff line change
`@@ -1343,6 +1343,8 @@ bool ColPartition::HasGoodBaseline() {`
`1343`	`1343`	`width = last_pt.x() - first_pt.x();`
`1344`	`1344`	`}`
`1345`	`1345`	`// Maximum median error allowed to be a good text line.`
	`1346`	`+ if (height_count == 0)`
	`1347`	`+ return false;`
`1346`	`1348`	`double max_error = kMaxBaselineError * total_height / height_count;`
`1347`	`1349`	`ICOORD start_pt, end_pt;`
`1348`	`1350`	`double error = linepoints.Fit(&start_pt, &end_pt);`