classify/mastertraining: Fix memory leaks

stweil · stweil · commit 1327551b49d3 · 2016-10-24T13:50:42.000+02:00
Coverity report: CID 1164739 (#1 of 1): Resource leak (RESOURCE_LEAK) 18. leaked_storage: Variable frag going out of scope leaks the storage it points to. Signed-off-by: Stefan Weil <sw@weilnetz.de>
diff --git a/classify/mastertrainer.cpp b/classify/mastertrainer.cpp
@@ -877,6 +877,7 @@ void MasterTrainer::ReplaceFragmentedSamples() {
       if (good_ch != INVALID_UNICHAR_ID)
         good_junk[good_ch] = true;  // We want this one.
     }
+    delete frag;
   }
 #endif
   // For now just use all the junk that was from natural fragments.
@@ -891,6 +892,7 @@ void MasterTrainer::ReplaceFragmentedSamples() {
       junk_samples_.extract_sample(s);
       samples_.AddSample(frag_set.id_to_unichar(junk_id), sample);
     }
+    delete frag;
   }
   junk_samples_.DeleteDeadSamples();
   junk_samples_.OrganizeByFontAndClass();

Original file line number	Diff line number	Diff line change
`@@ -877,6 +877,7 @@ void MasterTrainer::ReplaceFragmentedSamples() {`
`877`	`877`	`if (good_ch != INVALID_UNICHAR_ID)`
`878`	`878`	`good_junk[good_ch] = true; // We want this one.`
`879`	`879`	`}`
	`880`	`+ delete frag;`
`880`	`881`	`}`
`881`	`882`	`#endif`
`882`	`883`	`// For now just use all the junk that was from natural fragments.`
`@@ -891,6 +892,7 @@ void MasterTrainer::ReplaceFragmentedSamples() {`
`891`	`892`	`junk_samples_.extract_sample(s);`
`892`	`893`	`samples_.AddSample(frag_set.id_to_unichar(junk_id), sample);`
`893`	`894`	`}`
	`895`	`+ delete frag;`
`894`	`896`	`}`
`895`	`897`	`junk_samples_.DeleteDeadSamples();`
`896`	`898`	`junk_samples_.OrganizeByFontAndClass();`