This repository was archived by the owner on Nov 14, 2020. It is now read-only.
Add missing documentation specifying the database for postgresql_schema
#118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
calvinlfer
changed the title
postgresql_schema
cyrilgdn
suggested changes
Feb 6, 2020
There was a problem hiding this comment.
@calvinlfer Thanks for creating this PR, we indeed forgot to document this new field.
See my comment, your first assumption was right about the default value. Did you encounter another behavior?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there!
The current documentation for
postgres_schemadoesn't reference how to change the database that the schema is in. I assumed that it would use theproviderconfiguration to infer this but really it just defaults topostgresand it can be overridden via configuration so I just added some documentation for this feature.Cheers