Skip to content

add regions and require_corp_owned to access level module #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

daniel-cit
Copy link
Contributor

This PR adds support for:

in the the access level module.

@daniel-cit daniel-cit requested a review from bharathkkb October 24, 2020 01:00
Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @daniel-cit. Overall LGTM. Can we test this by modifying one of the existing examples?

@daniel-cit
Copy link
Contributor Author

Thanks @daniel-cit. Overall LGTM. Can we test this by modifying one of the existing examples?

I think they will need to be new tests so not to conflict with current tests.

I can do a negative regions test if we set the region in the access level to some region without a gcp location like for example PN. It should always fail in the tests

I don't think we will be able to test require_corp_owned because the organization that owns the access level must have an MDM license and we would need a device to be used in the test to originate request to resources inside the perimeter

@bharathkkb
Copy link
Member

I can do a negative regions test if we set the region in the access level to some region without a gcp location like for example PN. It should always fail in the tests

Not a blocker, but can't we modify one of the existing tests to include regions and then just assert via gcloud access-context-manager levels describe POLICY_NAME that it applies to that same list like "CH", "IT", "US",?

I don't think we will be able to test require_corp_owned because the organization that owns the access level must have an MDM license and we would need a device to be used in the test to originate request to resources inside the perimeter

Thanks for checking, sgtm.

@daniel-cit daniel-cit requested a review from bharathkkb November 4, 2020 04:55
Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks @daniel-cit

@bharathkkb bharathkkb merged commit 20d4ce5 into terraform-google-modules:master Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants