mark the database password as sensitive #98
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es#99) * Create parameter group with custom name * Allow setting of parameter group description too * Move locals into main.tf * Include "no_prefix" resource in output * Update all README files with terraform docs
* Add tags to enhanced_monitoring iam_role * give priority to tags defined by user
* Remove unused submodule output This breaks plan when trying to create a read replica without setting the master password. module.database.module.db_instance.local.this_db_instance_password: local.this_db_instance_password: Resource 'aws_db_instance.this' does not have attribute 'password' for variable 'aws_db_instance.this.*.password' * Add postgres and mysql replica example
* add support for max_allocated_storage * add support for max_allocated_storage * add support for max_allocated_storage * max_allocated_storage into documentation * changed required type to 'number'
…modules#147) * Add var.performance_insights_retention_period * Add performance insights retention docs
|
@mattyjones would you mind rebasing to fix merge conflicts when you get a chance? |
bryantbiggs
added a commit
to bryantbiggs/terraform-aws-rds
that referenced
this pull request
Dec 15, 2019
… mattyjones-master
|
@mattyjones v2.8.0 has been just released with this minor fix. |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When doing a plan or when an error log is produced the database password is exposed. This should not be the case and I believe marking this as sensative will solve this according the current docs.