feat: Add support for network_type
#431
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krewenki
changed the title
krewenki
changed the title
bryantbiggs
requested changes
Sep 11, 2022
bryantbiggs
changed the title
network_type
antonbabenko
pushed a commit
that referenced
this pull request
Sep 11, 2022
## [5.1.0](v5.0.3...v5.1.0) (2022-09-11) ### Features * Add support for `network_type` ([#431](#431)) ([a277924](a277924))
|
This PR is included in version 5.1.0 🎉 |
|
QQ, does changing |
|
@chenrui333 I assume that if you are not changing the value itself (but rather importing existing value), it should not prompt you to recreate anything. I have not tried this myself. |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for the
network_typeargument.Motivation and Context
I've got RDS clusters in production that need to be deployed in dual-stack mode, and this module didn't support that configuration yet. Instead of maintaining a private fork, I will submit a patch.
Breaking Changes
The required AWS provider is bumped from 4.6 to 4.28. This version is where the network_type argument became available.
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request