Skip to content

Fix / CA Cert Instance Default #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

bryantbiggs
Copy link
Member

Description

  • Update db_instance sub-module to use same default ca_cert_identifier as the root level module default

- Update `db_instance` submodule to use same default ca_cert_identifier as the root level module default
Copy link

@vutny vutny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, @bryantbiggs !

@antonbabenko, please consider to merge it.
From https://docs.aws.amazon.com/AmazonRDS/latest/UserGuide/UsingWithRDS.SSL-certificate-rotation.html

The current CA certificates expire on March 5, 2020. Therefore, we strongly recommend completing this change as soon as possible, to avoid disruption on the expiration date. If the change is not completed, your applications will fail to connect to your RDS DB instances using SSL/TLS after March 5, 2020.

@antonbabenko antonbabenko merged commit a0ddbff into terraform-aws-modules:master Feb 10, 2020
@antonbabenko
Copy link
Member

Thanks @bryantbiggs !

v2.14.0 has been just released.

@bryantbiggs bryantbiggs deleted the fix/ca-cert-instance-default branch February 10, 2020 15:07
@robinbowes
Copy link
Contributor

@antonbabenko Do we need this in the terreform11 branch too?

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants