variable "source_db" , for rds replica option #13
Conversation
modules/db_instance/main.tf
Outdated
| @@ -17,6 +17,8 @@ resource "aws_db_instance" "this" { | |||
| password = "${var.password}" | |||
| port = "${var.port}" | |||
|
|
|||
| replicate_source_db = "${var.source_db}" | |||
There was a problem hiding this comment.
use variable and value the same - "replicate_source_db" (not "source_db")
There was a problem hiding this comment.
updated: replicate_source_db = "${var.replicate_source_db}"
modules/db_instance/variables.tf
Outdated
| @@ -21,6 +21,11 @@ variable "kms_key_id" { | |||
| default = "" | |||
| } | |||
|
|
|||
| variable "source_db" { | |||
| description = "The master DB for replica" | |||
There was a problem hiding this comment.
Make description more informative (follow official documentation):
Specifies that this resource is a Replicate database, and to use this value as the source database. This correlates to the identifier of another Amazon RDS Database to replicate.
There was a problem hiding this comment.
description improved
-unify replicate_source_db var and value -standarize var description
|
Last changes commented in-line. |
|
Rebase this PR, please. |
examples/complete/main.tf
Outdated
| @@ -44,6 +44,9 @@ module "db" { | |||
| backup_window = "03:00-06:00" | |||
| backup_retention_period = 0 // disable backups to create DB faster | |||
|
|
|||
| # On replica option - Source DB for RDS replica | |||
| replicate_source_db = "${var.replicate_source_db}" | |||
There was a problem hiding this comment.
Let's remove this from example, because it won't be used so often.
|
Thanks @agomezvidalee ! Your code has been released as v1.1.1. |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Allow origin database for RDS replica.