Skip to content

Add optional support for ALB logging #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 26, 2019
Merged

Add optional support for ALB logging #49

merged 2 commits into from
Apr 26, 2019

Conversation

brainsik
Copy link
Contributor

Adds variables so the Atlantis ALB will log to a specified S3 bucket using a specified prefix. By default, logging is disabled to be backwards compatible.

Adds variables so the Atlantis ALB will log to a specified S3 bucket using a specified prefix. By default, logging is disabled to be backwards compatible.
@brainsik
Copy link
Contributor Author

@antonbabenko Let me know if there's anything I can do to help get this merged in. We're currently running off our forked copy and I'd love to get back on the mainline. Thanks!

@antonbabenko antonbabenko merged commit 9150d5a into terraform-aws-modules:master Apr 26, 2019
@antonbabenko
Copy link
Member

Thanks, Jeremy!

v1.17.0 has been released.

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants