Skip to content

Workaround to not error on accessing value on a data element that does not exist #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 7, 2019
Merged

Workaround to not error on accessing value on a data element that does not exist #42

merged 1 commit into from
Mar 7, 2019

Conversation

amitch23
Copy link
Contributor

@amitch23 amitch23 commented Mar 6, 2019

We are using a pre-created cert and passing in an ACM cert arn (certificate_arn), using a domain name that's not Route53 (create_route53_record = false), and the acm cert module invocation errors with:

Error: Error running plan: 1 error(s) occurred:

* module.atlantis.module.acm.var.zone_id: Resource 'data.aws_route53_zone.this' not found for variable 'data.aws_route53_zone.this.id'

This is a workaround for terraform to not error when invoking the ACM cert module when not using route53, and not creating an ACM cert..

@amitch23
Copy link
Contributor Author

amitch23 commented Mar 7, 2019

hi @antonbabenko, would you be able to have a look at this PR at your convenience? Thanks!

@antonbabenko
Copy link
Member

Looks good. Thank you!

@antonbabenko antonbabenko merged commit c527c9a into terraform-aws-modules:master Mar 7, 2019
@antonbabenko
Copy link
Member

v1.13.0 has been released.

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants