Support ECS volumes independent of EFS (for init containers)

[staticaland]

Is your request related to a new offering from AWS?

No.

Is your request related to a problem? Please describe.

Currently, the module forces volume configuration to be tied to EFS (enable_efs). This means we can't use standard ECS volumes for common use cases like init containers that need to share files with the main Atlantis container.

A specific example is needing to configure Atlantis Slack webhooks, which according to the documentation must be configured via the server side config file. This is not the same as the server-side repo config.

• ATLANTIS_REPO_CONFIG is the path to the server-side repo config.
• ATLANTIS_REPO_CONFIG_JSON lets you specify the server-side repo config as a JSON string directly
• ATLANTIS_CONFIG is the path to the server-side config.
• There is no JSON string option like the repo config has.

Describe the solution you'd like.

Allow volume configuration to work independently of the EFS setting. Something like this:

volume = { for k, v in merge(
    var.enable_efs ? {
      efs = {
        efs_volume_configuration = {
          file_system_id     = module.efs.id
          transit_encryption = "ENABLED"
          authorization_config = {
            access_point_id = try(module.efs.access_points["atlantis"].id, null)
            iam             = "ENABLED"
          }
        }
      }
    } : {},
    lookup(var.service, "volume", {})
) : k => v if k == "efs" ? var.enable_efs : true }

I'm not 100% sure this code is correct for all cases, but it works in my case.

This enables use cases like:

service = {
  volume = {
    atlantis-config = {
      name = "atlantis-config"
    }
  }
  container_definitions = {
    init-config = {
      mount_points = [{
        sourceVolume = "atlantis-config"
        containerPath = "/config"
      }]
    }
  }
}

  atlantis = {
    dependencies = [
      {
        containerName = "init-config"
        condition     = "COMPLETE"
      }
    ]
    mount_points = [
      {
        sourceVolume  = "atlantis-config"
        containerPath = "/etc/atlantis"
        readOnly      = true
      }
    ]
}

I can show a full example if necessary.

Describe alternatives you've considered.

1. Use EFS - but I feel it's unnecessary.
2. Use enable_efs = true with create = false - but this isn't possible as creation is tied to enable_efs. Even if it did work, it would be an ugly solution.

[github-actions]

This issue has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this issue will be closed in 10 days

[staticaland]

Still valuable 🤗

[github-actions]

This issue has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this issue will be closed in 10 days

[am-zest]

I have the same issue. I need this!

[github-actions]

This issue has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this issue will be closed in 10 days

[yngvark]

Still need this.

[github-actions]

This issue has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this issue will be closed in 10 days