Skip to content

Expose /metrics endpoint through unauthenticated access #364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cblkwell opened this issue Oct 17, 2023 · 2 comments · Fixed by #366
Closed

Expose /metrics endpoint through unauthenticated access #364

cblkwell opened this issue Oct 17, 2023 · 2 comments · Fixed by #366

Comments

@cblkwell
Copy link

Is your request related to a problem? Please describe.

For many cases, such as exposing to an external provider, it would be nice to be able to expose the /metrics endpoint via an unauthenticated connection like we do /events to certain IP ranges (our Prometheus server, or DataDog collectors, or whatever).

Describe the solution you'd like.

The best method here is probably to just define another variable like allow_unauthenticated_metrics_cidr_blocks and allow_unauthenticated_metrics_priority as there is for github webhooks, and then add a new aws_alb_listener_rule resource similar to the one for /events.

Describe alternatives you've considered.

We can add this listener rule resource ourself outside of the module (which is what we're doing now) but it would be nicer if it was just integrated into the module.

@antonbabenko
Copy link
Member

This issue has been resolved in version 4.0.0 🎉

Copy link

github-actions bot commented Dec 5, 2023

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants